variable-name: don't crash on syntax errors (#3292)

[bugfix] `variable-name` fixed crash on empty variable name Fixes: #3288
palantir · Oct 19, 2017 · e406628 · e406628
1 parent d197ee3
commit e406628
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/rules/variableNameRule.ts b/src/rules/variableNameRule.ts
@@ -151,7 +151,7 @@ function walk(ctx: Lint.WalkContext<Options>): void {
             return;
         }
 
-        if (!isCamelCase(text, options) && !isUpperCase(text)) {
+        if (text.length !== 0 && !isCamelCase(text, options) && !isUpperCase(text)) {
             ctx.addFailureAtNode(name, formatFailure());
         }
     }

diff --git a/test/rules/variable-name/allow-pascal-case/test.ts.lint b/test/rules/variable-name/allow-pascal-case/test.ts.lint
@@ -43,3 +43,8 @@ let optionallyValid_ = "bar";
     ~~~~~~~~~~~~~~~~          [variable name must be in lowerCamelCase, PascalCase or UPPER_CASE]
 let _$httpBackend_ = "leading and trailing";
     ~~~~~~~~~~~~~~          [variable name must be in lowerCamelCase, PascalCase or UPPER_CASE]
+
+// don't crash on syntax errors
+
+class {}
+let {bar:} = foo;