Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new rule: jsx-whitespace-literal #243

Merged
merged 2 commits into from Aug 1, 2019
Merged

add new rule: jsx-whitespace-literal #243

merged 2 commits into from Aug 1, 2019

Conversation

tanmoyopenroot
Copy link
Contributor

PR checklist

Overview of change:

Added jsx-whitespace-literal rule with some tests

{
    "rules": {
        "jsx-whitespace-literal": true
    }
}

Is there anything you'd like reviewers to focus on?

Not sure if i covered all test

adidahiya
adidahiya suggested changes Jul 30, 2019
View reviewed changes
test/rules/jsx-whitespace-literal/test.tsx.lint Show resolved Hide resolved
test/rules/jsx-whitespace-literal/test.tsx.lint Outdated Show resolved Hide resolved
test/rules/jsx-whitespace-literal/test.tsx.lint Show resolved Hide resolved
src/rules/jsxWhitespaceLiteralRule.ts Outdated Show resolved Hide resolved
src/rules/jsxWhitespaceLiteralRule.ts Outdated Show resolved Hide resolved
@adidahiya adidahiya merged commit 55d8a53 into palantir:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rule: jsx-whitespace-literal
2 participants
@tanmoyopenroot @adidahiya