Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove unneeded babel plugins #2111

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

abdonrd
Copy link
Collaborator

@abdonrd abdonrd commented Mar 12, 2021

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2021

🦋 Changeset detected

Latest commit: 2d45a2d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@open-wc/building-rollup Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure these are unneeded? In particular I know some down steam tools (bundlephobia, etc.) are not so keen on these syntaxes...

I'm happy to have this removed, if that's the right call, however.

@abdonrd
Copy link
Collaborator Author

abdonrd commented Apr 20, 2021

Any news here?

@LarsDenBakker
Copy link
Member

@Westbrook yes this can be removed, there is another babel pass that compiles it away as well.

@LarsDenBakker LarsDenBakker merged commit b55fb7b into open-wc:master Apr 20, 2021
@abdonrd abdonrd deleted the babel-plugins branch April 20, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants