refactor: remove obsolete requestMedia option

octokit · Apr 26, 2018 · d672afe · d672afe
1 parent 417d3bd
commit d672afe
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 7 deletions.
diff --git a/lib/defaults.js b/lib/defaults.js
@@ -1,7 +1,8 @@
 module.exports = {
   agent: undefined, // https://nodejs.org/api/https.html#https_class_https_agent
-  headers: {},
-  requestMedia: 'application/vnd.github.v3+json',
+  headers: {
+    accept: 'application/vnd.github.v3+json'
+  },
   timeout: 0,
   baseUrl: 'https://api.github.com'
 }
diff --git a/lib/parse-client-options.js b/lib/parse-client-options.js
@@ -9,8 +9,7 @@ const OPTION_NAMES = [
   'timeout',
   'baseUrl',
   'agent',
-  'headers',
-  'requestMedia'
+  'headers'
 ]
 
 function parseOptions (userOptions) {

diff --git a/scripts/templates/index.d.ts.tpl b/scripts/templates/index.d.ts.tpl
@@ -35,7 +35,6 @@ declare namespace Github {
     baseUrl?: string;
     timeout?: number;
     headers?: {[header: string]: any};
-    requestMedia?: string;
     agent?: http.Agent;
 
     /**

diff --git a/scripts/templates/index.js.flow.tpl b/scripts/templates/index.js.flow.tpl
@@ -14,7 +14,6 @@ declare module "github" {
     proxy?: string;
     ca?: string;
     headers?: {[header: Header]: any};
-    requestMedia?: string;
     rejectUnauthorized?: boolean;
     family?: number;
   };

diff --git a/test/typescript-validate.ts b/test/typescript-validate.ts
@@ -16,8 +16,8 @@ export default async function() {
   // for all supported options
   const octokit = new Octokit({
     timeout: 0,
-    requestMedia: 'application/vnd.github.v3+json',
     headers: {
+      accept: 'application/vnd.github.v3+json',
       'user-agent': 'octokit/rest.js v1.2.3'
     },
     baseUrl: 'https://api.github.com',