Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Remove networking requirements from many of our tests #15085

Closed
wants to merge 5 commits into from
Closed

Remove networking requirements from many of our tests #15085

wants to merge 5 commits into from

Conversation

iarna
Copy link
Contributor

@iarna iarna commented Dec 1, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 85.604% when pulling 3779437 on iarna/denetwork-tests into a2a9ba7 on release-next.

zkat
zkat approved these changes Dec 1, 2016
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't exhaustive, but it takes care of several instances of networked tests. LGTM! 🎉

@zkat zkat added this to the next milestone Dec 1, 2016
@zkat zkat removed the review label Dec 1, 2016
zkat pushed a commit that referenced this pull request Dec 1, 2016
@iarna @zkat
test: Remove network dependency from install-test test
bc32afe 
PR-URL: #15085
Credit: @iarna
Reviewed-By: @zkat
zkat pushed a commit that referenced this pull request Dec 1, 2016
@iarna @zkat
test: Remove network dependency from outdated-symlink test
c8a22fe 
PR-URL: #15085
Credit: @iarna
Reviewed-By: @zkat
zkat pushed a commit that referenced this pull request Dec 1, 2016
@iarna @zkat
test: Remove network dependency from bearer-token-check test
db2666d 
PR-URL: #15085
Credit: @iarna
Reviewed-By: @zkat
zkat pushed a commit that referenced this pull request Dec 1, 2016
@iarna @zkat
test: Remove network dependency from legacy-optional-deps test
744a39b 
PR-URL: #15085
Credit: @iarna
Reviewed-By: @zkat
zkat pushed a commit that referenced this pull request Dec 1, 2016
@iarna @zkat
test: Make node tests compatible with windows
868e691 
PR-URL: #15085
Credit: @iarna
Reviewed-By: @zkat
@zkat zkat force-pushed the release-next branch 2 times, most recently from d9bb42b to e1c7ae8 Compare December 2, 2016 00:56
@zkat
Copy link
Contributor

zkat commented Dec 2, 2016

Merged and included in npm@4.0.5

@zkat zkat closed this Dec 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
target-latest
Projects
None yet
Milestone
4.0.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iarna @coveralls @zkat