Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

dedupe: Remove unused code #15083

Merged
merged 1 commit into from Dec 1, 2016
Merged

dedupe: Remove unused code #15083

merged 1 commit into from Dec 1, 2016

Conversation

iarna
Copy link
Contributor

@iarna iarna commented Dec 1, 2016

Remove useless normalizeTree override. This was needed back before loadCurrentTree used readGlobalPackageData for globals.

@iarna
dedupe: Remove unused code
7f460a7 
Remove useless normalizeTree override. This was needed back before
loadCurrentTree used readGlobalPackageData for globals.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 85.484% when pulling 7f460a7 on iarna/remove-now-useless-code-in-dedupe into a2a9ba7 on release-next.

@zkat zkat removed the review label Dec 1, 2016
zkat
zkat approved these changes Dec 1, 2016
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to Rebecca and the tests already pass. This is ded. LGTM!

@zkat zkat merged this pull request into release-next Dec 1, 2016
@zkat zkat added this to the next milestone Dec 1, 2016
zkat pushed a commit that referenced this pull request Dec 1, 2016
@iarna @zkat
dedupe: Remove unused code
f0f7b0f 
Remove useless normalizeTree override. This was needed back before
loadCurrentTree used readGlobalPackageData for globals.

PR-URL: #15083
Credit: @iarna
Reviewed-By: @zkat
@iarna iarna deleted the iarna/remove-now-useless-code-in-dedupe branch March 7, 2017 23:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
target-latest
Projects
None yet
Milestone
4.0.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iarna @coveralls @zkat