Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

inflate-bundled: Initialize nodes from bundled dependencies #15082

Merged
merged 1 commit into from Dec 1, 2016
Merged

inflate-bundled: Initialize nodes from bundled dependencies #15082

merged 1 commit into from Dec 1, 2016

Conversation

iarna
Copy link
Contributor

@iarna iarna commented Dec 1, 2016 •
edited

This solves the root cause of the errors where an attempt to read node.package.devDependencies crashes because devDependencies is not defined.

Fixes: #14427

@iarna
Copy link
Contributor Author

iarna commented Dec 1, 2016

I am having the damnedest time coming up with a repro for this, even believing I know the root cause. That is, I haven't figured out what combination of bundles and shrinkwraps and modules on disk produce this scenario.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 85.465% when pulling 8dd0b1d on iarna/fix-bundled-node-expansion into a2a9ba7 on release-next.

@zkat zkat removed the review label Dec 1, 2016
zkat
zkat approved these changes Dec 1, 2016
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering how difficult this one is to repro, I'd like to have something at least in place for folks dealing with the issue. Let's just avoid closing the connected issue(s) until we have an actual test case for it, though.

@zkat zkat added this to the next milestone Dec 1, 2016
@zkat zkat merged this pull request into release-next Dec 1, 2016
zkat pushed a commit that referenced this pull request Dec 1, 2016
@iarna @zkat
inflate-bundled: Initialize nodes from bundled dependencies
fc61c08 
Note: There's no test for this because it's really easy to repro. Until then, the connected issue (#14427) and others, should not be closed.

PR-URL: #15082
Credit: @iarna
Reviewed-By: @zkat
@zkat zkat mentioned this pull request Dec 2, 2016
Closed
3 tasks
@zkat zkat mentioned this pull request Dec 15, 2016
Closed
@iarna iarna deleted the iarna/fix-bundled-node-expansion branch March 8, 2017 00:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
needs-tests target-latest
Projects
None yet
Milestone
4.0.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iarna @coveralls @zkat