Working on old nodes

nodejs · Feb 9, 2018 · b4a83e0 · b4a83e0
1 parent fa8729c
commit b4a83e0
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 54 deletions.
diff --git a/build/build.js b/build/build.js
@@ -149,6 +149,8 @@ pump(
             file !== 'test-stream-base-no-abort.js' &&
             file !== 'test-stream-preprocess.js' &&
             file !== 'test-stream-inheritance.js' &&
+            file !== 'test-stream-base-prototype-accessors.js' &&
+            file !== 'test-stream-base-prototype-accessors-enumerability.js'  &&
             file !== 'test-stream-base-typechecking.js') {
           processTestFile(file)
         }

diff --git a/build/test-replacements.js b/build/test-replacements.js
@@ -194,9 +194,9 @@ module.exports['common.js'] = [
   '}).enable();*/'
 ],
 [
-  /const async_wrap = process\.binding\('async_wrap'\);\n.*var kCheck = async_wrap\.constants\.kCheck;/gm,
-  '// const async_wrap = process.binding(\'async_wrap\');' +
-  '  // var kCheck = async_wrap.constants.kCheck;'
+  /(?:var|const) async_wrap = process\.binding\('async_wrap'\);\n.*(?:var|const) (?:{ )?kCheck(?: })? = async_wrap\.constants(?:\.kCheck)?;/gm,
+  '// const async_wrap = process.binding(\'async_wrap\');\n' +
+  '  // const kCheck = async_wrap.constants.kCheck;'
 ],
 [
   /async_wrap\.async_hook_fields\[kCheck\] \+= 1;/,

diff --git a/test/common/index.js b/test/common/index.js
@@ -105,8 +105,8 @@ exports.projectDir = path.resolve(__dirname, '..', '..');
 
 // Always enable async_hooks checks in tests
 {
-  var async_wrap = process.binding('async_wrap');
-  var kCheck = async_wrap.constants.kCheck;
+  // const async_wrap = process.binding('async_wrap');
+  // const kCheck = async_wrap.constants.kCheck;
   // async_wrap.async_hook_fields[kCheck] += 1;
 
   exports.revert_force_async_hooks_checks = function () {

diff --git a/test/parallel/test-stream-base-prototype-accessors-enumerability.js b/test/parallel/test-stream-base-prototype-accessors-enumerability.js
diff --git a/test/parallel/test-stream-base-prototype-accessors.js b/test/parallel/test-stream-base-prototype-accessors.js