Implement callback on req.write and req.end #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2018
gr2m
approved these changes
Jan 8, 2018
|
Thank you so much for finding the real cause of the problem and sending a great PR with tests 🙏:bow: much appreciated. Have a fabulous week! |
Limess
pushed a commit
to Limess/fastly-promises
that referenced
this pull request
Jan 15, 2018
Fixes issue caused by axios follow-redirects dependency update nock/nock#1047
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node.js write and end methods take a callback as third argument; this pull request also adds them to the Nock interface.
Fixes #1046 and #1044.