Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nock does not respect callback parameters on req.write and req.end #1046

Closed
RubenVerborgh opened this issue Jan 8, 2018 · 1 comment
Closed

Comments

@RubenVerborgh
Copy link
Contributor

RubenVerborgh commented Jan 8, 2018

Node's req.write and req.end accept callback parameters, but Nock does not. This is the cause of #1044 / follow-redirects/follow-redirects#77 / axios/axios#1271.

Fix in #1047.

@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant