Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: request.end accepted arguments #1591

Merged
merged 2 commits into from
Jul 7, 2019
Merged

fix: request.end accepted arguments #1591

merged 2 commits into from
Jul 7, 2019

Commits on Jun 21, 2019

  1. Fix typo about wrapping request.end. 

    I'm making this change it's own commit so I have a place to comment the
findings.

Digging through Node git history, I found the change that created the
breaking change in nock (ref nock PR 929).
nodejs/node@a10bdb5#diff-286202fdbdd74ede6f5f5334b6176b5cL779

Before Node v8, `OutgoingMessage`, which is extended by `ClientRequest`,
would literally do what it says in the docs if data was provided. It
would call `this.write(data, encoding)`. This meant that nock could wrap
only the `write` method when recording and gather all the chunks even if
the last chunk was sent to `end`. But, the above changed that to call an
internal function dual used by `end` and `write`.
    @mastermatt
    mastermatt committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    d24eda6 View commit details
    Browse the repository at this point in the history

  2. fix: request.end accepted arguments. 

    Fixes nock#1549

The method now correctly accepts all the permutations allowed.
request.end(data, encoding, callback)
request.end(data, callback)
request.end(data, encoding)
request.end(data)
request.end(callback)
request.end()

And a few tests were added to ensure all cases are explicitly covered.
    @mastermatt
    mastermatt committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    308dc83 View commit details
    Browse the repository at this point in the history