test: Improve tests for header matching with function; adopt new promise-rejection assertion #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction 1. Assert the expected argument is passed. (It's the correct argument, though not the expected type!) 2. When the function returns true, assert the request matches. 3. When the function returns false, assert the request doesn't match. 4. When the function returns false, assert the mock is not consumed. (This test is failing, which is a bug.
|
merge at your convenience, I’m not 100% sure if you want to add to it |
|
Yea, thanks, let's merge it. |
|
🎉 This PR is included in version 11.0.0-beta.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
…ise-rejection assertion (#1481) 1. Assert the expected argument is passed. (It's the correct argument, though not the expected type!) 2. When the function returns true, assert the request matches. 3. When the function returns false, assert the request doesn't match. 4. When the function returns false, assert the mock is not consumed. 5. I added copies of these tests for `matchHeader` called on the interceptor instead of the scope. Test 4 uncovered an unexpected behavior in tap, which is that `t.rejects` causes our `afterEach` hook to fire – since it's implemented as a subtest. Not knowing how to work around this, I replaced our uses of `t.rejects` with a promise-rejection assertion that does not rely on a subtest. Ref: #1305 (comment) and tapjs/tapjs#525
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
…ise-rejection assertion (#1481) 1. Assert the expected argument is passed. (It's the correct argument, though not the expected type!) 2. When the function returns true, assert the request matches. 3. When the function returns false, assert the request doesn't match. 4. When the function returns false, assert the mock is not consumed. 5. I added copies of these tests for `matchHeader` called on the interceptor instead of the scope. Test 4 uncovered an unexpected behavior in tap, which is that `t.rejects` causes our `afterEach` hook to fire – since it's implemented as a subtest. Not knowing how to work around this, I replaced our uses of `t.rejects` with a promise-rejection assertion that does not rely on a subtest. Ref: #1305 (comment) and tapjs/tapjs#525
gr2m
pushed a commit
that referenced
this pull request
Sep 5, 2019
…ise-rejection assertion (#1481) 1. Assert the expected argument is passed. (It's the correct argument, though not the expected type!) 2. When the function returns true, assert the request matches. 3. When the function returns false, assert the request doesn't match. 4. When the function returns false, assert the mock is not consumed. 5. I added copies of these tests for `matchHeader` called on the interceptor instead of the scope. Test 4 uncovered an unexpected behavior in tap, which is that `t.rejects` causes our `afterEach` hook to fire – since it's implemented as a subtest. Not knowing how to work around this, I replaced our uses of `t.rejects` with a promise-rejection assertion that does not rely on a subtest. Ref: #1305 (comment) and tapjs/tapjs#525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matchHeadercalled on the interceptor instead of the scope.Test 4 uncovered an unexpected behavior in tap, which is that
t.rejectscauses ourafterEachhook to fire – since it's implemented as a subtest.Not knowing how to work around this, I replaced our uses of
t.rejectswith a promise-rejection assertion that does not rely on a subtest.Ref: #1305 (comment) and tapjs/tapjs#525
This was prompted by #1480, however this isn't related to that bug (which so far I can't reproduce).