Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error when leading slash is not present in path #1391

Merged
merged 3 commits into from
Jan 25, 2019
Merged

Throw error when leading slash is not present in path #1391

merged 3 commits into from
Jan 25, 2019

Commits on Jan 23, 2019

  1. add leading slash when is not present in path 

    Previously, whenever you intercept a path with no leading slash nock will
not resolve the URL correctly. This fixes the issue by adding a leading
slash if required while creating an Interceptor.

Check #1259 to know more.
    @kevinnio
    kevinnio committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    f984b6a View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2019

  1. add "uri can be a regexp too" comment

    @kevinnio
    kevinnio committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    dda4793 View commit details
    Browse the repository at this point in the history

  2. raise error instead of adding leading slash 

    Given #1391 (comment), we
decided to make nock raise an error whenever the user forgets to add a
leading slash into the intercepted path, instead of adding it itself.
    @kevinnio
    kevinnio committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    f4acf40 View commit details
    Browse the repository at this point in the history