http.IncomingMessage destroy does not work properly

[b4dnewz]

I'm not sure if is a bug or else but I've a situation where I rely on res.destroy to manually raise an error.

What is the expected behavior?
res.destroy should emit an error event and error is passed as an argument to any listeners on the event

What is the actual behavior?
res.destroy is never called or does not emit error

How to reproduce the issue

const nock = require('nock');
const http = require('http');

nock("http://example.com")
  .get("/robots.txt")
  .reply(404);

http.get("http://example.com/robots.txt", (res) => {
  if (res.statusCode !== 200) {
    res.destroy(new Error("Response error"))
    return;
  }
}).on("error", (err) => {
  console.log("Called with error", err);
});

Versions

Software	Version(s)
Nock	^10.0.6
Node	10.15.3

[paulmelnikow]

Here's the docs:

https://nodejs.org/api/http.html#http_message_destroy_error

Seems like this would be a good addition to the mock surface. Would you like to make a PR?

It's been a moment since I've looked at this, though I think the method would be added in request_overrider.js. The tests could go in their own file though I think they could be modeled on e.g. test_abort.js.

[b4dnewz]

yes I would like to contribute; I'll take a look at this, thanks for the code suggestions

[paulmelnikow]

Awesome! Let us know if you have any questions.

[nockbot]

🎉 This issue has been resolved in version 11.2.0 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[nockbot]

🎉 This issue has been resolved in version 11.2.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀