Weekly Digest (11 August, 2019 - 18 August, 2019)

[weekly-digest]

Here's the Weekly Digest for nock/nock:

---

ISSUES

Last week 14 issues were created.
Of these, 5 issues have been closed and 9 issues are still open.

OPEN ISSUES

💚 #1679 refactor: Fix two tests that don't work on an airplane, by paulmelnikow
💚 #1678 refactor: Refactor recorder stringification, by paulmelnikow
💚 #1677 refactor: Separate concerns of interceptor brokering and playback (+ other minor refactors), by paulmelnikow
💚 #1676 feat(types): Add Typescript definitions., by mastermatt
💚 #1675 Feat: Added response.destroy method, by b4dnewz
💚 #1673 refactor!: Refactor exports to reduce indirection, by paulmelnikow
💚 #1671 11.x release notes, by paulmelnikow
💚 #1670 TypeScript definitions, by paulmelnikow
💚 #1669 http.IncomingMessage destroy does not work properly, by b4dnewz

CLOSED ISSUES

❤️ #1674 refactor: Refactor RequestOverrider, by paulmelnikow
❤️ #1672 refactor: Convert Interceptor to a class, by paulmelnikow
❤️ #1668 chore(dep): remove unneeded dev dep acron, by mastermatt
❤️ #1667 Update rimraf to the latest version 🚀, by greenkeeper[bot]
❤️ #1666 Update acorn to the latest version 🚀, by greenkeeper[bot]

LIKED ISSUE

👍 #1669 http.IncomingMessage destroy does not work properly, by b4dnewz
It received 👍 x1, 😄 x0, 🎉 x0 and ❤️ x0.

NOISY ISSUE

🔈 #1673 refactor!: Refactor exports to reduce indirection, by paulmelnikow
It received 6 comments.

---

PULL REQUESTS

Last week, 9 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 4 pull requests were updated.
💛 #1677 refactor: Separate concerns of interceptor brokering and playback (+ other minor refactors), by paulmelnikow
💛 #1673 refactor!: Refactor exports to reduce indirection, by paulmelnikow
💛 #1671 11.x release notes, by paulmelnikow
💛 #1649 feat: afterRecord now returns object or stringified., by krackerman

MERGED PULL REQUEST

Last week, 5 pull requests were merged.
💜 #1674 refactor: Refactor RequestOverrider, by paulmelnikow
💜 #1672 refactor: Convert Interceptor to a class, by paulmelnikow
💜 #1668 chore(dep): remove unneeded dev dep acron, by mastermatt
💜 #1667 Update rimraf to the latest version 🚀, by greenkeeper[bot]
💜 #1664 bug(overrider): unmocked HTTPS request with partial interceptor match, by mastermatt

---

COMMITS

Last week there were 5 commits.
🛠️ chore(dep): remove unneeded dev dep acron (#1668) closes: #1666 by mastermatt
🛠️ refactor: Refactor RequestOverrider (#1674) This makes RequestOverrider into a class and breaks its logic up into several shorter methods. The goal is to make this code easier to understand, and easier to change. There is more that can be done here, though this seems like a meaningful place to pause. by paulmelnikow
🛠️ refactor: Convert Interceptor to a class (#1672) by paulmelnikow
🛠️ chore(package): update rimraf to version 3.0.0 (#1667) by greenkeeper[bot]
🛠️ [bug(overrider): unmocked HTTPS request with partial interceptor match (#1664) Fixes: #1422

The allowUnmocked option is processed in two places. Once in the
intercept when there are no interceptors that come close to matching
the request. And again in the overrider when there are interceptors
that partially match, eg just path, but don't completely match.

This fixes and explicitly tests the later case in the overrider by
making an HTTPS request for a path that has an interceptor but fails to
match the query constraint.](870584b) by mastermatt

---

CONTRIBUTORS

Last week there were 3 contributors.
👤 mastermatt
👤 paulmelnikow
👤 greenkeeper[bot]

---

STARGAZERS

Last week there were 24 stagazers.
⭐ jxjj
⭐ truckfondue
⭐ Ethan-Arrowood
⭐ cnzsb
⭐ rodrigoterminus
⭐ BtheGit
⭐ aizigao
⭐ Belzee10
⭐ lucaspbordignon
⭐ RiCoTeRoX
⭐ dragonfly429
⭐ aeosipov
⭐ igorkamyshev
⭐ pinussilvestrus
⭐ robertcoopercode
⭐ alexey-danilin
⭐ benunternaehrer
⭐ wildhaber
⭐ birnan
⭐ phishy
⭐ vinodh99
⭐ hughrun
⭐ rohitkrishna094
⭐ 38elements
You all are the stars! 🌟

---

RELEASES

Last week there was 1 release.
🚀 v11.0.0@next v11.0.0@next

---

That's all for last week, please 👀 Watch and ⭐ Star the repository nock/nock to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆