Replace request with axios #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@XhmikosR review? |
XhmikosR
reviewed
Nov 30, 2019
| @@ -1,6 +1,7 @@ | |||
| 'use strict'; | |||
| // @ts-check | |||
| @@ -61,7 +63,7 @@ describe('sendToCoveralls', () => { | |||
|
|
|||
| // set up mock process.stdout.write temporarily | |||
| const origStdoutWrite = process.stdout.write; | |||
| process.stdout.write = function(string, ...args) { | |||
| process.stdout.write = function (string, ...args) { | |||
|
@cktang88 my main concern is if everything will work fine in case of exceptions. /CC @nickmerwin |
|
Also, TBH I'm not sure I'd go with axios. Maybe node-fetch or got (8.x for Node.js 6.x support) would be a better choice. |
|
@nickmerwin this can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #204
Uses: https://bundlephobia.com/result?p=axios@0.19.0
Should save around 170kb gzipped