Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(common): add option to allow validation of custom decorators #2304

Merged

Conversation

TheNoim
Copy link
Contributor

@TheNoim TheNoim commented May 30, 2019

No matter what the reason is to not validate custom decorators, you should be able to at least provide an option

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2010

You are required to create a new validation pipe for custom decorators. You cannot use the build in one.

What is the new behavior?

You have the option to allow the validation of custom decorators.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

No matter what the reason is to not validate custom decorators, you should be able to at least provide an option
@kamilmysliwiec
Copy link
Member

Great, thanks! Would you like to add a PR to the docs as well? (see options table https://docs.nestjs.com/pipes#the-built-in-validationpipe)

@coveralls
Copy link

coveralls commented May 30, 2019

Pull Request Test Coverage Report for Build 3038

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 95.247%

Totals Coverage Status
Change from base Build 3034: 0.001%
Covered Lines: 3427
Relevant Lines: 3598

💛 - Coveralls

TheNoim added a commit to TheNoim/docs.nestjs.com that referenced this pull request May 30, 2019
@kamilmysliwiec kamilmysliwiec merged commit 31d53cd into nestjs:master May 30, 2019
@lock
Copy link

lock bot commented Sep 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants