Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option --report-by-task #176

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JochenDiekenbrock
Copy link

To resolve #175 I have added an option --report-by-task. If this option is true, two reports are created for each task: (task).out and (task).err

The existing tests all pass.

I have done some manual testing with and without this option invoking npm-run-all from the command line and so far, it works as I would expect. If you think it's a good idea to add this option, I would

  • add unit tests for this option
  • add another optional parameter to define a path/file template for the task reports, for example --report-name="my/path/whatever-{1}". Given the tasks would be "build test", this would create the files:
    • "my/path/whatever-build.out"
    • "my/path/whatever-build.err"
    • "my/path/whatever-test.out"
    • "my/path/whatever-test.err"

Any feedback welcome

@JochenDiekenbrock
Copy link
Author

More questions :-)
Would my changes work for sequential tasks as well?
And what about run-p and run-s? Is there anything to do?
Do I have to do anything else to be able to use this option from the npm-run-all api?

@codecov
Copy link

codecov bot commented Jul 6, 2019

Codecov Report

Merging #176 into master will decrease coverage by 2.46%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   92.58%   90.12%   -2.47%     
==========================================
  Files          22       23       +1     
  Lines         472      496      +24     
==========================================
+ Hits          437      447      +10     
- Misses         35       49      +14
Impacted Files Coverage Δ
bin/npm-run-all/main.js 100% <ø> (ø) ⬆️
bin/common/parse-cli-args.js 91.2% <0%> (-2.05%) ⬇️
lib/index.js 93.82% <100%> (+0.07%) ⬆️
lib/create-task-streams.js 25% <25%> (ø)
lib/run-task.js 81.48% <62.5%> (-5.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2260f5...f2a076e. Read the comment docs.

@JochenDiekenbrock
Copy link
Author

@mysticatea From your status, you seem to be very busy. But it would be great to get some feedback. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output redirect or pipe in task
1 participant