Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support exotic manifests #169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zkochan
Copy link

@zkochan zkochan commented May 5, 2019

pnpm v3.3.0 will support package.json5 and package.yaml (pnpm v3.3.0-0 is already out with the support).

This implementation involves a pnpm library that only supports Node.js>=8.15, so I understand if it will be rejected. Also, a test is required. Just want to know if you'd be fine supporting it. If no, I will publish a fork for pnpm usage.

Support package.json5 and package.yaml

BREAKING CHANGE:

Node.js>=8.15 is required
@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #169 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   92.94%   92.93%   -0.02%     
==========================================
  Files          22       22              
  Lines         468      467       -1     
==========================================
- Hits          435      434       -1     
  Misses         33       33
Impacted Files Coverage Δ
lib/read-package-json.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5017a88...8cc806c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #169 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   92.94%   92.93%   -0.02%     
==========================================
  Files          22       22              
  Lines         468      467       -1     
==========================================
- Hits          435      434       -1     
  Misses         33       33
Impacted Files Coverage Δ
lib/read-package-json.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5017a88...8cc806c. Read the comment docs.

@devinrhode2
Copy link

HOT DAMN! PNPM HAS BEEN SUPPORTING package.json5 THIS WHOLE TIME???
"Where have I been living" -patrick star

@ghost
Copy link

ghost commented Dec 7, 2022

@zkochan @aleee1333 @mysticatea whats the status of this ? Is this going in, or is there a fork already ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants