Fix: ensure "version" always has a valid value in parseOptions #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 43 43
Lines 1065 1065
=======================================
Hits 1046 1046
Misses 19 19
Continue to review full report at Codecov.
|
|
Oh, thank you for the contribution! It looks a regression in #99 I had overlooked. |
The rule no-unsupported-features would sometimes fail with a TypeError:
```
Error while loading rule 'node/no-unsupported-features': Cannot read property 'split' of null
TypeError: Error while loading rule 'node/no-unsupported-features': Cannot read property 'split' of null
at new Range (.../node_modules/semver/semver.js:780:20)
at Function.intersects (.../node_modules/semver/semver.js:1305:8)
at Object.freeze.features.Object.freeze.OPTIONS.reduce (.../node_modules/eslint-plugin-node/lib/rules/no-unsupported-features.js:191:44)
at Array.reduce (<anonymous>)
at parseOptions (.../node_modules/eslint-plugin-node/lib/rules/no-unsupported-features.js:175:41)
at Object.create (.../node_modules/eslint-plugin-node/lib/rules/no-unsupported-features.js:281:25)
```
This happens, when neither "engines" are set in the "package.json",
nor "version" is set in the rule configuration but the rule still has
configuration options, because version will then be set to
`options.version`, even if that is `undefined`.
This commit ensures that `version` always has a valid value before
trying to construct a semver range from it.
ZauberNerd
force-pushed
the
ensure-version-no-unsupported-features
branch
from
e995a59
to
25aac0a
Compare
|
@mysticatea updated, please take another look :) |
|
Hi @mysticatea just wanted to ask whether you had time already to take another look at this and if there's anything I can help with to get the fix released. |
mysticatea
approved these changes
Feb 23, 2018
|
No worries, thank you! |
mysticatea
added a commit
that referenced
this pull request
Feb 23, 2018
This was referenced Mar 17, 2018
ota-meshi
pushed a commit
to ota-meshi/eslint-plugin-node
that referenced
this pull request
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule no-unsupported-features would sometimes fail with a TypeError:
This happens, when neither "engines" are set in the "package.json",
nor "version" is set in the rule configuration but the rule still has
configuration options, because version will then be set to
options.version, even if that isundefined.This commit ensures that
versionalways has a valid value beforetrying to construct a semver range from it.