🐛 fix no-unpublished-bin false positive (fixes #115)

mysticatea · Jan 4, 2019 · e2fc482 · e2fc482
1 parent 0225b02
commit e2fc482
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/lib/util/get-npmignore.js b/lib/util/get-npmignore.js
@@ -84,18 +84,17 @@ function parseWhiteList(files) {
     }
 
     const ig = ignore()
-    ig.add("*")
 
     for (const file of files) {
         if (typeof file === "string" && file) {
-            const prefix = file.startsWith("!") ? "" : "!"
+            const prefix = file.startsWith("!") ? "!" : ""
             const body = file.replace(SLASH_AT_BEGIN_AND_END, "")
             ig.add(`${prefix}/${body}`)
             ig.add(`${prefix}/${body}/**`)
         }
     }
 
-    return not(ig.createFilter())
+    return ig.createFilter()
 }
 
 /**

diff --git a/tests/fixtures/no-unpublished-bin/issue115/package.json b/tests/fixtures/no-unpublished-bin/issue115/package.json
@@ -0,0 +1,7 @@
+{
+    "private": true,
+    "name": "test",
+    "version": "1.0.0",
+    "bin": {"a": "lib/a.js"},
+    "files": ["lib/a.js"]
+}
diff --git a/tests/lib/rules/no-unpublished-bin.js b/tests/lib/rules/no-unpublished-bin.js
@@ -63,6 +63,10 @@ new RuleTester().run("no-unpublished-bin", rule, {
             code: "'multi-npmignore/lib/a.js'",
             filename: fixture("multi-npmignore/lib/a.js"),
         },
+        {
+            code: "'issue115/lib/a.js'",
+            filename: fixture("issue115/lib/a.js"),
+        },
 
         // empty name
         "'stdin'",