Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Breaking: update no-deprecated-api rule
  • Loading branch information
mysticatea committed Oct 27, 2018
1 parent 044ecce commit 5860795
Show file tree
Hide file tree
Showing 2 changed files with 71 additions and 0 deletions.
30 changes: 30 additions & 0 deletions docs/rules/no-deprecated-api.md
Expand Up @@ -37,12 +37,16 @@ This rule reports the following deprecated API.
- [SlowBuffer class](https://nodejs.org/dist/v6.0.0/docs/api/buffer.html#buffer_class_slowbuffer)
- constants (undocumented)
- crypto
- [_toBuf](https://nodejs.org/dist/v11.0.0/docs/api/deprecations.html#deprecations_dep0114_crypto_tobuf)
- `Credentials` (undocumented)
- [DEFAULT_ENCODING](https://nodejs.org/dist/v10.0.0/docs/api/crypto.html#crypto_crypto_default_encoding)
- [createCredentials](https://nodejs.org/dist/v0.12.0/docs/api/crypto.html#crypto_crypto_createcredentials_details)
- [createCipher](https://nodejs.org/dist/v10.0.0/docs/api/crypto.html#crypto_crypto_createcipher_algorithm_password_options)
- [createDecipher](https://nodejs.org/dist/v10.0.0/docs/api/crypto.html#crypto_crypto_createdecipher_algorithm_password_options)
- [fips](https://nodejs.org/dist/v10.0.0/docs/api/crypto.html#crypto_crypto_fips)
- [prng](https://nodejs.org/dist/v11.0.0/docs/api/deprecations.html#deprecations_dep0115_crypto_prng_crypto_pseudorandombytes_crypto_rng)
- [pseudoRandomBytes](https://nodejs.org/dist/v11.0.0/docs/api/deprecations.html#deprecations_dep0115_crypto_prng_crypto_pseudorandombytes_crypto_rng)
- [rng](https://nodejs.org/dist/v11.0.0/docs/api/deprecations.html#deprecations_dep0115_crypto_prng_crypto_pseudorandombytes_crypto_rng)
- [domain](https://nodejs.org/dist/v4.0.0/docs/api/domain.html#domain_domain)
- events
- [EventEmitter.listenerCount](https://nodejs.org/dist/v4.0.0/docs/api/events.html#events_class_method_eventemitter_listenercount_emitter_event)
Expand All @@ -59,6 +63,12 @@ This rule reports the following deprecated API.
- [GLOBAL](https://nodejs.org/api/deprecations.html#deprecations_dep0016_global_root)
- [root](https://nodejs.org/api/deprecations.html#deprecations_dep0016_global_root)
- [Intl.v8BreakIterator](https://nodejs.org/api/deprecations.html#deprecations_dep0017_intl_v8breakiterator)
- [COUNTER_NET_SERVER_CONNECTION](https://nodejs.org/dist/v11.0.0/docs/api/deprecations.html#deprecations_dep0120_windows_performance_counter_support)
- [COUNTER_NET_SERVER_CONNECTION_CLOSE](https://nodejs.org/dist/v11.0.0/docs/api/deprecations.html#deprecations_dep0120_windows_performance_counter_support)
- [COUNTER_HTTP_SERVER_REQUEST](https://nodejs.org/dist/v11.0.0/docs/api/deprecations.html#deprecations_dep0120_windows_performance_counter_support)
- [COUNTER_HTTP_SERVER_RESPONSE](https://nodejs.org/dist/v11.0.0/docs/api/deprecations.html#deprecations_dep0120_windows_performance_counter_support)
- [COUNTER_HTTP_CLIENT_REQUEST](https://nodejs.org/dist/v11.0.0/docs/api/deprecations.html#deprecations_dep0120_windows_performance_counter_support)
- [COUNTER_HTTP_CLIENT_RESPONSE](https://nodejs.org/dist/v11.0.0/docs/api/deprecations.html#deprecations_dep0120_windows_performance_counter_support)
- http
- [createClient](https://nodejs.org/dist/v0.10.0/docs/api/http.html#http_http_createclient_port_host)
- module
Expand All @@ -72,6 +82,7 @@ This rule reports the following deprecated API.
- process
- `EventEmitter` (undocumented)
- `assert` (undocumented)
- [binding](https://nodejs.org/dist/v10.9.0/docs/api/deprecations.html#deprecations_dep0111_process_binding)
- [punycode](https://nodejs.org/dist/v7.0.0/docs/api/punycode.html)
- readline
- `codePointAt` (undocumented)
Expand All @@ -94,6 +105,9 @@ This rule reports the following deprecated API.
- [parseCertString](https://nodejs.org/dist/v8.6.0/docs/api/deprecations.html#deprecations_dep0076_tls_parsecertstring)
- tty
- [setRawMode](https://nodejs.org/dist/v0.10.0/docs/api/tty.html#tty_tty_setrawmode_mode)
- url
- [parse](https://nodejs.org/dist/v11.0.0/docs/api/deprecations.html#deprecations_dep0116_legacy_url_api)
- [resolve](https://nodejs.org/dist/v11.0.0/docs/api/deprecations.html#deprecations_dep0116_legacy_url_api)
- util
- [debug](https://nodejs.org/dist/v0.12.0/docs/api/util.html#util_util_debug_string)
- [error](https://nodejs.org/dist/v0.12.0/docs/api/util.html#util_util_error)
Expand Down Expand Up @@ -158,12 +172,16 @@ This option can include the following values:
- `new buffer.Buffer()`
- `buffer.SlowBuffer`
- `constants`
- `crypto._toBuf`
- `crypto.Credentials`
- `crypto.DEFAULT_ENCODING`
- `crypto.createCipher`
- `crypto.createCredentials`
- `crypto.createDecipher`
- `crypto.fips`
- `crypto.prng`
- `crypto.pseudoRandomBytes`
- `crypto.rng`
- `domain`
- `events.EventEmitter.listenerCount`
- `events.listenerCount`
Expand All @@ -183,6 +201,7 @@ This option can include the following values:
- `path._makeLong`
- `process.EventEmitter`
- `process.assert`
- `process.binding`
- `process.env.NODE_REPL_HISTORY_FILE`
- `punycode`
- `readline.codePointAt`
Expand All @@ -199,6 +218,8 @@ This option can include the following values:
- `tls.createSecurePair`
- `tls.parseCertString`
- `tty.setRawMode`
- `url.parse`
- `url.resolve`
- `util.debug`
- `util.error`
- `util.isArray`
Expand Down Expand Up @@ -242,10 +263,17 @@ This option can include the following values:

- `Buffer()`
- `new Buffer()`
- `COUNTER_NET_SERVER_CONNECTION`
- `COUNTER_NET_SERVER_CONNECTION_CLOSE`
- `COUNTER_HTTP_SERVER_REQUEST`
- `COUNTER_HTTP_SERVER_RESPONSE`
- `COUNTER_HTTP_CLIENT_REQUEST`
- `COUNTER_HTTP_CLIENT_RESPONSE`
- `Intl.v8BreakIterator`
- `require.extensions`
- `process.EventEmitter`
- `process.assert`
- `process.binding`
- `process.env.NODE_REPL_HISTORY_FILE`

Examples of :+1: **correct** code for the `{"ignoreGlobalItems": ["new Buffer()"]}`:
Expand Down Expand Up @@ -283,6 +311,8 @@ This rule cannot report the following cases:

- fs
- `fs.truncate()` and `fs.truncateSync()` usage with a file descriptor has been deprecated.
- url
- `url.format()` with legacy `urlObject` has been deprecated.

### dynamic things

Expand Down
41 changes: 41 additions & 0 deletions lib/rules/no-deprecated-api.js
Expand Up @@ -80,6 +80,9 @@ const modules = {
},
},
crypto: {
_toBuf: {
[READ]: { since: "11.0.0", replacedBy: null },
},
Credentials: {
[READ]: { since: "0.12.0", replacedBy: "'tls.SecureContext'" },
},
Expand All @@ -104,6 +107,15 @@ const modules = {
replacedBy: "'crypto.getFips()' and 'crypto.setFips()'",
},
},
prng: {
[READ]: { since: "11.0.0", replacedBy: "'crypto.randomBytes()'" },
},
pseudoRandomBytes: {
[READ]: { since: "11.0.0", replacedBy: "'crypto.randomBytes()'" },
},
rng: {
[READ]: { since: "11.0.0", replacedBy: "'crypto.randomBytes()'" },
},
},
domain: {
[READ]: { since: "4.0.0", replacedBy: null },
Expand Down Expand Up @@ -191,6 +203,9 @@ const modules = {
assert: {
[READ]: { since: "10.0.0", replacedBy: "'require(\"assert\")'" },
},
binding: {
[READ]: { since: "10.9.0", replacedBy: null },
},
env: {
NODE_REPL_HISTORY_FILE: {
[READ]: { since: "4.0.0", replacedBy: "'NODE_REPL_HISTORY'" },
Expand Down Expand Up @@ -283,6 +298,14 @@ const modules = {
},
},
},
url: {
parse: {
[READ]: { since: "11.0.0", replacedBy: "'url.URL' constructor" },
},
resolve: {
[READ]: { since: "11.0.0", replacedBy: "'url.URL' constructor" },
},
},
util: {
debug: {
[READ]: { since: "0.12.0", replacedBy: "'console.error()'" },
Expand Down Expand Up @@ -368,6 +391,24 @@ const globals = {
replacedBy: "'Buffer.alloc()' or 'Buffer.from()'",
},
},
COUNTER_NET_SERVER_CONNECTION: {
[READ]: { since: "11.0.0", replacedBy: null },
},
COUNTER_NET_SERVER_CONNECTION_CLOSE: {
[READ]: { since: "11.0.0", replacedBy: null },
},
COUNTER_HTTP_SERVER_REQUEST: {
[READ]: { since: "11.0.0", replacedBy: null },
},
COUNTER_HTTP_SERVER_RESPONSE: {
[READ]: { since: "11.0.0", replacedBy: null },
},
COUNTER_HTTP_CLIENT_REQUEST: {
[READ]: { since: "11.0.0", replacedBy: null },
},
COUNTER_HTTP_CLIENT_RESPONSE: {
[READ]: { since: "11.0.0", replacedBy: null },
},
GLOBAL: {
[READ]: { since: "6.0.0", replacedBy: "'global'" },
},
Expand Down

0 comments on commit 5860795

Please sign in to comment.