Skip to content

Commit

Permalink
⚒ fix test failing
Browse files Browse the repository at this point in the history
  • Loading branch information
@mysticatea
mysticatea committed May 2, 2019
1 parent 2061413 commit 0972d6e
Show file tree
Hide file tree
Showing 3 changed files with 48 additions and 54 deletions.
2 changes: 1 addition & 1 deletion lib/util/check-unsupported-builtins.js
View file
Expand Up @@ -50,7 +50,7 @@ module.exports = function checkUnsupportedBuiltins(context, trackMap) {
messageId: "unsupported",
data: {
name,
supported: info.supported,
supported: info.supported || "???",
version: options.version.raw,
},
})
Expand Down
12 changes: 6 additions & 6 deletions tests/lib/rules/no-unsupported-features/es-syntax.js
View file
Expand Up @@ -2440,11 +2440,11 @@ ruleTester.run(
},
{
filename: fixture("invalid/a.js"),
code: "var a = (b,) => 1",
code: "var a = { ...obj }",
errors: [
{
messageId: "no-trailing-function-commas",
data: { supported: "8.0.0", version: ">=6.0.0" },
messageId: "no-rest-spread-properties",
data: { supported: "8.3.0", version: ">=8.0.0" },
},
],
},
Expand All @@ -2460,11 +2460,11 @@ ruleTester.run(
},
{
filename: fixture("nothing/a.js"),
code: "var a = (b,) => 1",
code: "var a = { ...obj }",
errors: [
{
messageId: "no-trailing-function-commas",
data: { supported: "8.0.0", version: ">=6.0.0" },
messageId: "no-rest-spread-properties",
data: { supported: "8.3.0", version: ">=8.0.0" },
},
],
},
Expand Down
88 changes: 41 additions & 47 deletions tests/lib/rules/no-unsupported-features/node-builtins.js
View file
Expand Up @@ -2165,7 +2165,7 @@ new RuleTester({
},
{
code: "require('dns').promises",
options: [{ version: "10.6.0" }],
options: [{ version: "11.14.0" }],
},

// Ignores
Expand Down Expand Up @@ -2197,7 +2197,9 @@ new RuleTester({
},
{
code: "require('dns').promises",
options: [{ version: "10.5.9", ignores: ["dns.promises"] }],
options: [
{ version: "11.13.9", ignores: ["dns.promises"] },
],
},
],
invalid: [
Expand Down Expand Up @@ -2287,14 +2289,14 @@ new RuleTester({
},
{
code: "require('dns').promises",
options: [{ version: "10.5.9" }],
options: [{ version: "11.13.9" }],
errors: [
{
messageId: "unsupported",
data: {
name: "dns.promises",
supported: "10.6.0",
version: "10.5.9",
supported: "11.14.0",
version: "11.13.9",
},
},
],
Expand All @@ -2309,23 +2311,23 @@ new RuleTester({
valid: [
{
code: "require('fs').promises",
options: [{ version: "10.1.0" }],
options: [{ version: "11.14.0" }],
},
{
code: "var fs = require('fs'); fs.promises",
options: [{ version: "10.1.0" }],
options: [{ version: "11.14.0" }],
},
{
code: "var { promises } = require('fs'); promises",
options: [{ version: "10.1.0" }],
options: [{ version: "11.14.0" }],
},
{
code: "import fs from 'fs'; fs.promises",
options: [{ version: "10.1.0" }],
options: [{ version: "11.14.0" }],
},
{
code: "import { promises } from 'fs'",
options: [{ version: "10.1.0" }],
options: [{ version: "11.14.0" }],
},
{
code: "require('fs').copyFile",
Expand Down Expand Up @@ -2355,23 +2357,23 @@ new RuleTester({
// Ignores
{
code: "require('fs').promises",
options: [{ version: "10.0.9", ignores: ["fs.promises"] }],
options: [{ version: "11.13.9", ignores: ["fs.promises"] }],
},
{
code: "var fs = require('fs'); fs.promises",
options: [{ version: "10.0.9", ignores: ["fs.promises"] }],
options: [{ version: "11.13.9", ignores: ["fs.promises"] }],
},
{
code: "var { promises } = require('fs'); promises",
options: [{ version: "10.0.9", ignores: ["fs.promises"] }],
options: [{ version: "11.13.9", ignores: ["fs.promises"] }],
},
{
code: "import fs from 'fs'; fs.promises",
options: [{ version: "10.0.9", ignores: ["fs.promises"] }],
options: [{ version: "11.13.9", ignores: ["fs.promises"] }],
},
{
code: "import { promises } from 'fs'",
options: [{ version: "10.0.9", ignores: ["fs.promises"] }],
options: [{ version: "11.13.9", ignores: ["fs.promises"] }],
},
{
code: "require('fs').copyFile",
Expand Down Expand Up @@ -2412,70 +2414,70 @@ new RuleTester({
invalid: [
{
code: "require('fs').promises",
options: [{ version: "10.0.9" }],
options: [{ version: "11.13.9" }],
errors: [
{
messageId: "unsupported",
data: {
name: "fs.promises",
supported: "10.1.0",
version: "10.0.9",
supported: "11.14.0",
version: "11.13.9",
},
},
],
},
{
code: "var fs = require('fs'); fs.promises",
options: [{ version: "10.0.9" }],
options: [{ version: "11.13.9" }],
errors: [
{
messageId: "unsupported",
data: {
name: "fs.promises",
supported: "10.1.0",
version: "10.0.9",
supported: "11.14.0",
version: "11.13.9",
},
},
],
},
{
code: "var { promises } = require('fs'); promises",
options: [{ version: "10.0.9" }],
options: [{ version: "11.13.9" }],
errors: [
{
messageId: "unsupported",
data: {
name: "fs.promises",
supported: "10.1.0",
version: "10.0.9",
supported: "11.14.0",
version: "11.13.9",
},
},
],
},
{
code: "import fs from 'fs'; fs.promises",
options: [{ version: "10.0.9" }],
options: [{ version: "11.13.9" }],
errors: [
{
messageId: "unsupported",
data: {
name: "fs.promises",
supported: "10.1.0",
version: "10.0.9",
supported: "11.14.0",
version: "11.13.9",
},
},
],
},
{
code: "import { promises } from 'fs'",
options: [{ version: "10.0.9" }],
options: [{ version: "11.13.9" }],
errors: [
{
messageId: "unsupported",
data: {
name: "fs.promises",
supported: "10.1.0",
version: "10.0.9",
supported: "11.14.0",
version: "11.13.9",
},
},
],
Expand Down Expand Up @@ -4900,14 +4902,6 @@ new RuleTester({
//----------------------------------------------------------------------
{
valid: [
{
code: "require('worker_threads')",
options: [{ version: "10.5.0" }],
},
{
code: "import worker_threads from 'worker_threads'",
options: [{ version: "10.5.0" }],
},
{
code: "require('worker_threads')",
options: [
Expand All @@ -4924,42 +4918,42 @@ new RuleTester({
invalid: [
{
code: "require('worker_threads')",
options: [{ version: "10.4.99" }],
options: [{ version: "10.5.0" }],
errors: [
{
messageId: "unsupported",
data: {
name: "worker_threads",
supported: "10.5.0",
version: "10.4.99",
supported: "???",
version: "10.5.0",
},
},
],
},
{
code: "import worker_threads from 'worker_threads'",
options: [{ version: "10.4.99" }],
options: [{ version: "10.5.0" }],
errors: [
{
messageId: "unsupported",
data: {
name: "worker_threads",
supported: "10.5.0",
version: "10.4.99",
supported: "???",
version: "10.5.0",
},
},
],
},
{
code: "import { Worker } from 'worker_threads'",
options: [{ version: "10.4.99" }],
options: [{ version: "10.5.0" }],
errors: [
{
messageId: "unsupported",
data: {
name: "worker_threads",
supported: "10.5.0",
version: "10.4.99",
supported: "???",
version: "10.5.0",
},
},
],
Expand Down

0 comments on commit 0972d6e

Please sign in to comment.