Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migration from wrapper divs to Fragments #129

Merged
merged 6 commits into from
Dec 23, 2017

Conversation

cherniavskii
Copy link
Member

  • I have changed my target branch to develop 馃憡

Description

Closes #93

This PR changes unnecessary wrapper divs to React Fragments.

In React 16.2.0 Fragment was added as name export, which is handy.
But using named export requires to set react to 16.2.0 in peerDependencies, which may be not cool.
We could leave react 16.0.0 in peerDependencies, but instead of importing Fragment like this:

import { Fragment } from 'react'
.....
<Fragment> ....

we should get it from React default export:

import React from 'react'
.....
<React.Fragment> ....

I'd prefer the second solution, but I would like to hear someone else's opinion ;)

@dmtrKovalenko dmtrKovalenko merged commit deb621d into develop Dec 23, 2017
@cherniavskii
Copy link
Member Author

cherniavskii commented Dec 23, 2017

@dmtrKovalenko so you are okay with not supporting react <16.2.0?

@dmtrKovalenko
Copy link
Member

@cherniavskii I think yes, we are not supporting 15, but there is no actually breaking changes between 16.0.0 & 16.2.0

@cherniavskii
Copy link
Member Author

@dmtrKovalenko yeah, migration from 16.0.0 to 16.2.0 is painless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants