Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript declaration files for cbStorePut. #872

Merged
merged 1 commit into from Oct 18, 2018

Conversation

ogis-fujiwara
Copy link
Contributor

I missed to update declaration files for cbStorePut of #869.

@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #872 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #872   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files           8        8           
  Lines         877      877           
  Branches      232      232           
=======================================
  Hits          828      828           
  Misses         49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f94cb75...b0d8c23. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogis-fujiwara
Copy link
Contributor Author

@mcollina, please merge this PR before release 3.0.0.

@mcollina mcollina merged commit 1684819 into mqttjs:master Oct 18, 2018
redboltz pushed a commit to redboltz/MQTT.js that referenced this pull request May 19, 2019
Update TypeScript declaration files for `cbStorePut`.
redboltz pushed a commit to redboltz/MQTT.js that referenced this pull request May 19, 2019
Update TypeScript declaration files for `cbStorePut`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants