server side disconnect handling (#926)

mqttjs · Mar 20, 2019 · 524699d · 524699d
1 parent 62641d6
commit 524699d
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 0 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -351,6 +351,10 @@ MqttClient.prototype._handlePacket = function (packet, done) {
       this._handlePingresp(packet)
       done()
       break
+    case 'disconnect':
+      this._handleDisconnect(packet)
+      done()
+      break
     default:
       // do nothing
       // maybe we should do an error handling
@@ -1257,6 +1261,17 @@ MqttClient.prototype._handlePubrel = function (packet, callback) {
   })
 }
 
+/**
+ * _handleDisconnect
+ *
+ * @param {Object} packet
+ * @api private
+ */
+MqttClient.prototype._handleDisconnect = function (packet) {
+  this.emit('close', packet)
+  this.end(true)
+}
+
 /**
  * _nextId
  * @return unsigned int

diff --git a/test/client.js b/test/client.js
@@ -880,6 +880,30 @@ describe('MqttClient', function () {
         client.subscribe('a/b', {qos: 1})
       })
     })
+    it('server side disconnect', function (done) {
+      this.timeout(15000)
+      var server327 = new Server(function (client) {
+        client.on('connect', function (packet) {
+          client.connack({
+            reasonCode: 0
+          })
+          client.disconnect({reasonCode: 128})
+          server327.close()
+        })
+      })
+      server327.listen(port + 327)
+      var opts = {
+        host: 'localhost',
+        port: port + 327,
+        protocolVersion: 5
+      }
+
+      var client = mqtt.connect(opts)
+      client.once('close', function (disconnectPacket) {
+        should(disconnectPacket.reasonCode).be.equal(128)
+        done()
+      })
+    })
     it('pubrec handling custom reason code', function (done) {
       this.timeout(15000)
       serverErr.listen(port + 117)