Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update node.js to v18 - abandoned #405

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 9, 2022

Mend Renovate

This PR contains the following updates:

Package Type Update Change
cimg/node docker major 14.19-browsers -> 18.10-browsers
cimg/node docker major 14.19 -> 18.10

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@rpl rpl requested a review from willdurand August 9, 2022 20:58
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #405 (4045dc8) into master (032bc57) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files           1        1           
  Lines         145      145           
=======================================
  Hits          132      132           
  Misses         13       13           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rpl
Copy link
Member

rpl commented Aug 9, 2022

@willdurand turned out that there was a corner case around that npm-global dir (the one previously used in our circleci config) that we still needed to fix:

annoyingly each of the cicleci nodejs docket images seems to have node and npm installed in a different way, the one we are currently using has likely node installed through nvm in a user writable location, while this one (and also the one from #403) seems to be using one installed globally and so npm install -g fails.

In 4045dc8 there is the simplest workaround I could think of, installing in another directory using npm install without -g and then add the resulting node_modules/.bin directory to the PATH env var.

@renovate renovate bot changed the title chore(deps): update node.js to v18 chore(deps): update node.js to v18 - abandoned Nov 20, 2022
@renovate
Copy link
Contributor Author

renovate bot commented Nov 20, 2022

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant