An attempt at handling errors in message passing (perhaps not the best approach) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like makeCallback, but checks for returned error-like objects, and converts them back to errors. Also, in Chrome, chrome.runtime.lastError (at least sometimes) seems not to be an Error, but an error-like object, so this is converted too (just using the same method as for onMessage, although I'm not sure if it's the best approach here).
Like wrapAsyncFunction, but uses makeCallbackForSendMessage
When returning from sendMessage, Firefox seems to convert anything that was thrown into a standard Error, with the message property of the Error getting the message property of what was thrown, if it was an object with a "truthy" message property, or "An unexpected error occurred" otherwise. I don't think Firefox returns anything else besides the message (i.e. not the type of error, filename, linenumber, etc.). To allow the same functionality, the message property is returned in an error-like object, to be converted to an Error on arrival.
Added the additional custom methods for sending and receiving messages.
An attempt to revert to original behaviour, to see if it will pass checking.
Attempt to partially restore onMessage change without breaking checks.
|
There's discussion about this issue in #97 (and this patch might conflict with that patch?) Also, I wonder if the test that failed after the spacing and comma were fixed might not have really been checking for desired behaviour?
If I understand this right, if onMessage catches a thrown string, it is expected to call sendResponse with that string? If so, I don't think this is really desired behaviour? |
Replaced several instances of: typeof [expression] == "object" with: typeof [expression] == "object" && expression To deal with cases where [expression] is null
|
This is no longer needed, as it is dealt with in #115. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at handling errors between onMessage and sendMessage.
It's perhaps not the best approach, because it duplicates a lot of code, so you might not want to use it as is, but perhaps there's something useful in it to inform a better approach?