Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove serialization. #727

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove serialization. #727

wants to merge 1 commit into from

Conversation

gbrail
Copy link
Collaborator

@gbrail gbrail commented Jun 24, 2020

Get rid of every class that implements "Serializable" and associated
machinery for readObject/writeObject and the like. Get rid of tests
that assume it's there (not very many of those actually).

Remove the "serialize" and "deserialize" commands from the shell.

Remove SerializableInputStream and SerializableOutputStream.

Closes #704

Get rid of every class that implements "Serializable" and associated
machinery for readObject/writeObject and the like. Get rid of tests
that assume it's there (not very many of those actually).

Remove the "serialize" and "deserialize" commands from the shell.

Remove SerializableInputStream and SerializableOutputStream.
@gbrail
Copy link
Collaborator Author

gbrail commented Jun 25, 2020

@rbri and others who are regularly running the latest Rhino -- any chance you can try this and see if it causes big problems? It removes some classes and support that were previously supported although I think that they were generally not used.

@rbri
Copy link
Collaborator

rbri commented Jun 27, 2020

@gbrail did a first quick test with you PR applied to the HtmlUnit branch. Looks correct so far - no regressions. I only had failing tests because HtmlUnit supports serialization of dom objects (Scriptables). This was expected and is something i have to solve inside HtmlUnit.
For me it is fine to go ahead with this.

@rbri
Copy link
Collaborator

rbri commented Jun 29, 2020

As this is a major change, maybe we can announce the plan and doing the next release without this. Then we will merge this directly after the release to have this for some time in the snapshots.

@gbrail
Copy link
Collaborator Author

gbrail commented Jun 29, 2020 via email

@tonygermano
Copy link
Contributor

See #704 (comment) from linked issue. It mentions that serialization is currently being used with continuations.

@p-bakker p-bakker added this to In progress in v2.0.0 via automation Nov 29, 2021
@p-bakker p-bakker moved this from In progress to To Discuss in v2.0.0 Nov 29, 2021
@EduFrazao
Copy link

Hi Folks. What is the goal/benefit of remove serialization support?
My application makes heavy use of server-side scripting, and they are hold into the application-server sessions.
We are evaluating support the distrubuition of http-sessions, wich will rely on serialize everything. This change will cause impact those scenario rigth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
v2.0.0
To Discuss
Development

Successfully merging this pull request may close these issues.

Proposal: Get rid of all serialization in Rhino
4 participants