MNTOR-3189: Upgrade to Next-Auth 5 #4519
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MNTOR-3110: (60 commits) ci: set cloudsql instead ci: new service ci: deploy cloudrun pointing to distinct db chore: del vercel deployment yml ci: lint MNTOR-3168 - Only show monthly monitor report pref to premium users (#4489) Import translations from l10n repository (2024-05-08) Don't send new users the monthly activity email bump npm and node versions everywhere chore(deps): bump @mozilla/glean from 4.0.0 to 5.0.1 chore(deps): bump pg from 8.11.3 to 8.11.5 chore(deps): bump winston from 3.12.0 to 3.13.0 chore(deps): bump nodemailer and @types/nodemailer chore(deps-dev): bump tsx from 4.7.3 to 4.9.3 chore(deps-dev): bump react-intersection-observer from 9.10.1 to 9.10.2 chore(deps): bump next-auth from 4.24.6 to 4.24.7 chore(deps-dev): bump @types/jsonwebtoken from 9.0.5 to 9.0.6 chore(deps-dev): bump sass from 1.72.0 to 1.77.0 chore(deps): bump canvas-confetti from 1.9.2 to 1.9.3 chore(deps): bump @types/node from 20.12.7 to 20.12.10 ...
Vinnl
changed the title
pdehaan
reviewed
May 15, 2024
| @@ -2,7 +2,7 @@ | |||
| APP_ENV=local | |||
| SERVER_URL=http://localhost:6060 | |||
| PORT=6060 | |||
| NEXTAUTH_URL=http://localhost:6060 | |||
There was a problem hiding this comment.
nit: might still have a few stray references in the GH Actions:
git grep "NEXTAUTH_URL" | cat
.github/workflows/e2e_cron.yml: NEXTAUTH_URL: ${{ secrets.NEXTAUTH_URL }}
.github/workflows/e2e_pr.yml: NEXTAUTH_URL: ${{ secrets.NEXTAUTH_URL }}
.github/workflows/preview_deploy_gcp.yml: NEXTAUTH_URL= ${{ secrets.NEXTAUTH_URL }}| @@ -2,7 +2,7 @@ | |||
| APP_ENV=local | |||
| SERVER_URL=http://localhost:6060 | |||
| PORT=6060 | |||
| NEXTAUTH_URL=http://localhost:6060 | |||
| AUTH_URL=http://localhost:6060 | |||
There was a problem hiding this comment.
Possibly related to the GH Actions comment, but not sure where/if this is used (or if next-auth just silently uses the env var). Only reference I can find to this env var is this one reference:
git grep -Pn "AUTH_URL" | grep -v "NEXTAUTH_URL"
.env-dist:5:AUTH_URL=http://localhost:6060
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3189
Figma:
Description
Screenshot (if applicable)
Not applicable.
How to test
Checklist (Definition of Done)