Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-3157: Preview Deploy Implementation #4448

Merged
merged 76 commits into from May 16, 2024
Merged

MNTOR-3157: Preview Deploy Implementation #4448

merged 76 commits into from May 16, 2024

Conversation

mansaj
Copy link
Collaborator

@mansaj mansaj commented Apr 25, 2024

References:

Jira: MNTOR-3157

Description

The first part of preview deployment:

  • Github action that will run on every PR:
    • generates a database with the PR number as namespace in GCP cloud SQL
    • set up the user, db table blurts
  • Build and deploy docker image to GCP artifact registry
  • Deploy the image to GCP Cloud Run
  • Comment the preview URL
  • Github action that cleans up all deployed services once this PR closes

What's not included or working:

  • FxA (login doesn't work), so the current preview deploy should work for landing page / breaches pages

How to test

  • Open a PR
  • Close a PR

Checklist (Definition of Done)

  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

Copy link

github-actions bot commented May 2, 2024

Preview URL 🚀 : https://run-8929692530---blurts-server-mgjlpikfea-uk.a.run.app

Copy link

github-actions bot commented May 2, 2024

Copy link

Copy link

Copy link

@mansaj mansaj requested a review from rhelmer May 14, 2024 18:23
Copy link

Copy link
Collaborator

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, I'm not sure we really need a separate Dockerfile (it's mostly duplicated) but I don't think it'll be too hard to keep up to date, we just might want to think about what the name of it will be.

.github/workflows/preview_deploy_gcp.yml Show resolved Hide resolved
Dockerfile_with_migrate Outdated Show resolved Hide resolved
Copy link

Copy link

Copy link

Copy link

@mansaj mansaj merged commit 55c18f5 into main May 16, 2024
15 checks passed
@mansaj mansaj deleted the MNTOR-3110 branch May 16, 2024 15:22
Copy link

Cleanup completed - database 'blurts-server-pr-4448' destroyed, cloud run service 'blurts-server-pr-4448' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants