Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send enforcement action to cinder & use jobs decision endpoint #22233

Conversation

eviljeff
Copy link
Member

@eviljeff eviljeff commented May 9, 2024

fixes mozilla/addons#14778 and fixes mozilla/addons#14779

Fixed these two issues together as they touched the same code (but as two commits). Now we send the enforcement action in addition to the policies a decision was made under, and if there's a job we use the new job specific endpoint for creating the decision (also means we don't need to close the job manually afterwards)

@eviljeff eviljeff requested a review from diox May 9, 2024 11:11
Copy link
Member

@diox diox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Haven't ran it locally but it matches the docs AFAICT so let's see it on dev.

@eviljeff eviljeff merged commit aa55108 into mozilla:master May 13, 2024
13 checks passed
Copy link

sentry-io bot commented May 14, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ConnectionError: b'{"detail": ["EnforcementActions with slugs 'amo-approve-version' does not exist"]}' olympia.abuse.tasks.resolve_job_in_cinder View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants