Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic docker props next #22232

Closed
wants to merge 5 commits into from
Closed

Dynamic docker props next #22232

wants to merge 5 commits into from

Conversation

KevinMind
Copy link
Contributor

Thanks for opening a Pull Request (PR), here's a few guidelines as to what we need in your PR before we review it.

Please delete anything that isn't relevant to your patch.

  • This PR relates to an existing open issue and there are no existing
    PRs open for the same issue.
  • Add Fixes #ISSUENUM at the top of your PR.
  • Add a description of the changes introduced in this PR.
  • The change has been successfully run locally.
  • Add tests to cover the changes added in this PR.
  • Add before and after screenshots (Only for changes that impact the UI).

Once you have met the above requirements please replace this section with
a Fixes #ISSUENUM linking to the issue fixed by this PR along with an
explanation of the changes. Thanks for your contribution!

Split docker compose to modular features
- base for global definition
- build to define build config
- mount deps to expose /deps in container on ./deps
- mount olympia to mount repository root
- simplify extract deps config

Use docker compose to run containers locally and in CI.

TMP: add pull config to pull instead of build

TMP: Experiment to make running more flexible and meausure the startup performance

TMP: run on PR

TMP: fix stuff

TMP: more fix

TMP: split it up
@KevinMind
Copy link
Contributor Author

KevinMind commented May 8, 2024

cold: clean repository no ignored files. empty buildx cache, empty local registry, no volumes
warm: immediately after running cold, no changes
warm (no ./deps): after running warm removing files in ./deps

Master:
cold: 12:31.85
warm: 4:53.33
warm (no ./deps): 8:12.75

Branch:
cold: 7:12.62, 8:12.40
warm: 5:40.36 6:08.89
* warm (no ./deps): 5:40.36 6:08.89

* values are identical as warm because ./deps is cleared as a part of initialization

@KevinMind KevinMind closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant