Implemented issue #253: Duration.toISO() doesn't include milliseconds (

#284)

Include milliseconds in Duration#toISO

.gitignore

@@ -3,4 +3,5 @@ node_modules
 build
 #*
 .#*
-coverage/
+coverage/
+.DS_Store

src/duration.js

@@ -381,6 +381,7 @@ export default class Duration {
    * @example Duration.fromObject({ months: 4, seconds: 45 }).toISO() //=> 'P4MT45S'
    * @example Duration.fromObject({ months: 5 }).toISO() //=> 'P5M'
    * @example Duration.fromObject({ minutes: 5 }).toISO() //=> 'PT5M'
+   * @example Duration.fromObject({ milliseconds: 6 }).toISO() //=> 'PT0.006S'
    * @return {string}
    */
   toISO() {
@@ -399,7 +400,8 @@ export default class Duration {
     if (norm.hours > 0 || norm.minutes > 0 || norm.seconds > 0 || norm.milliseconds > 0) s += 'T';
     if (norm.hours > 0) s += norm.hours + 'H';
     if (norm.minutes > 0) s += norm.minutes + 'M';
-    if (norm.seconds > 0) s += norm.seconds + 'S';
+    if (norm.seconds > 0 || norm.milliseconds > 0)
+      s += norm.seconds + norm.milliseconds / 1000 + 'S';
     return s;
   }
 

test/duration/format.test.js

@@ -16,7 +16,7 @@ const dur = () =>
 // #toISO()
 //------
 test('Duration#toISO fills out every field', () => {
-  expect(dur().toISO()).toBe('P1Y2M3DT4H5M6S');
+  expect(dur().toISO()).toBe('P1Y2M3DT4H5M6.007S');
 });
 
 test('Duration#toISO creates a minimal string', () => {
@@ -38,6 +38,10 @@ test('Duration#toISO returns null for invalid durations', () => {
   expect(Duration.invalid('because').toISO()).toBe(null);
 });
 
+test('Duration#toISO handles milliseconds duration', () => {
+  expect(Duration.fromObject({ milliseconds: 7 }).toISO()).toBe('PT0.007S');
+});
+
 //------
 // #toJSON()
 //------