Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor checkGlobals() error message creation #3711

Merged
merged 12 commits into from Feb 11, 2019
Merged

Refactor checkGlobals() error message creation #3711

merged 12 commits into from Feb 11, 2019

Commits on Feb 4, 2019

  1. feat(lib/utils.js): Add utility routines 

    Added two functions, sQuote and dQuote, for quoting text. Added ngettext function for message
translation for dealing with plurality.
    @plroebuck
    plroebuck committed Feb 4, 2019
    Copy the full SHA
    d613cd5 View commit details
    Browse the repository at this point in the history

  2. refactor(lib/runner.js): Refactor error creation of detected leaks 

    Simplified logic related to plurality in `checkGlobals`. Refactored `failHook` to use quotation for
hook title.
    @plroebuck
    plroebuck committed Feb 4, 2019
    Copy the full SHA
    0816417 View commit details
    Browse the repository at this point in the history

  3. test(unit/runner.spec.js): Update spec for leak detection change

    @plroebuck
    plroebuck committed Feb 4, 2019
    Copy the full SHA
    ff04d19 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into plroebuck/checkGlobals-refactor

    @plroebuck
    plroebuck committed Feb 4, 2019
    Copy the full SHA
    d7b4266 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. Merge branch 'master' into plroebuck/checkGlobals-refactor

    @plroebuck
    plroebuck committed Feb 5, 2019
    Copy the full SHA
    6585829 View commit details
    Browse the repository at this point in the history

  2. test(unit/runner.spec.js): Fix after rebase 

    Fixed for 'global.derp' test modifications. Removed test global previously uncleaned.
    @plroebuck
    plroebuck committed Feb 5, 2019
    Copy the full SHA
    17845e7 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. test(unit/runner.spec.js): Fix to emit using constant names

    @plroebuck
    plroebuck committed Feb 7, 2019
    Copy the full SHA
    470e562 View commit details
    Browse the repository at this point in the history

  2. test(integration/reporters.spec.js): Replace inline with call to util… 

    …s.dQuote

Use the 'utils' version of the function.
    @plroebuck
    plroebuck committed Feb 7, 2019
    Copy the full SHA
    5bb337d View commit details
    Browse the repository at this point in the history

  3. test(unit/utils.spec.js): Add tests for new methods

    @plroebuck
    plroebuck committed Feb 7, 2019
    Copy the full SHA
    36dbfbf View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2019

  1. refactor(lib/mocha.js): Use sQuote rather than hardcoded inline

    @plroebuck
    plroebuck committed Feb 8, 2019
    Copy the full SHA
    7ec4f1b View commit details
    Browse the repository at this point in the history

  2. test(integration/reporters.spec.js): Tweak access to dQuote

    @plroebuck
    plroebuck committed Feb 8, 2019
    Copy the full SHA
    dceaf8e View commit details
    Browse the repository at this point in the history

  3. refactor(lib/utils.js): Use quotation methods

    @plroebuck
    plroebuck committed Feb 8, 2019
    Copy the full SHA
    c7c7214 View commit details
    Browse the repository at this point in the history