Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an error when fn===undefined #3580

Merged
merged 7 commits into from Dec 28, 2018
Merged

Fix an error when fn===undefined #3580

merged 7 commits into from Dec 28, 2018

Commits on Nov 26, 2018

  1. Fix an error when fn===undefined 

    This change fixes an error that occurs when reporter is 'xunit' and run is called without callback: " /rbd/pnpm-volume/a49b9a7c-c3f0-42ba-ae66-612ead86e96c/node_modules/.registry.npmjs.org/mocha/5.2.0/node_modules/mocha/lib/reporters/xunit.js:126
 fn(failures);  ^
TypeError: fn is not a function "
    @Lana-Light
    Lana-Light committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    1e08057 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2018

  1. Add test .reporter("xunit").run(fn) 

    This test has `try catch` block to catch an error if it occurs and write it to the console.
    @Lana-Light
    Lana-Light committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    f5d8c7e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from Lana-Light/patch-3 

    Patch 3
    @Lana-Light
    Lana-Light committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    a8283dd View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2018

  1. formatting and updates

    @Lana-Light
    Lana-Light committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    7dd1e55 View commit details
    Browse the repository at this point in the history

  2. formatting

    @Lana-Light
    Lana-Light committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    e726d93 View commit details
    Browse the repository at this point in the history

  3. Update mocha.spec.js

    @Lana-Light
    Lana-Light committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    0eda3bd View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2 from Lana-Light/patch-4 

    Patch 4
    @Lana-Light
    Lana-Light committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    8736b46 View commit details
    Browse the repository at this point in the history