remove default js in "--watch-extensions" option; closes #3275 #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Originally I called this a "bug", but it's not. You can see from the original help text that it's acting in a way consistent with the documentation. That makes this a purely breaking change, so it necessitates a major release. This PR LGTM, but I want to discuss a branching/release plan with @mochajs/core before this is merged. |
boneskull
added
semver-major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Changes the behaviour of the
--watch-extensionsoption. No longer includesjsby default, meaning that the specified list becomes an exclusive and not an additional set of extensions.Benefits
Closes #3275.
Possible Drawbacks
Mocha will not behave as expected for people who rely on
jsfiles always being watched.Applicable issues
#3275