Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverts use of semistandard directly (#2648) #2795

Merged
merged 2 commits into from May 12, 2017
Merged

reverts use of semistandard directly (#2648) #2795

merged 2 commits into from May 12, 2017

Conversation

boneskull
Copy link
Member

Abstractions around ESLint are not widely supported in text editors or IDEs. For example, I could tell WebStorm to use node_modules/eslint-config-semistandard/eslintrc.json, but there's no way for WebStorm to know about the overrides in the semistandard prop of package.json, nor the overrides specified for test files in Makefile.

semistandard is arguably easier to use on the CLI, and requires less configuration files, but the cost to users primarily interfacing with ESLint via contextual information in an IDE (like myself!) outweighs the benefit.

cc @kt3k

@boneskull boneskull requested a review from Munter May 9, 2017 20:50
@boneskull
Copy link
Member Author

Worth mentioning: WebStorm supports standard, but not semistandard, nor xo.

@kt3k
Copy link
Contributor

kt3k commented May 9, 2017

@Flet
Can you see this issue? How do you think?

@kt3k
Copy link
Contributor

kt3k commented May 10, 2017

Personally I don't use editor integration for linting. I think this issue depends on people and the team who use it. If you evaluate the negative impact is bigger than the benefits here, I think it makes sense to switch back to eslint cli.

@Flet
Copy link

Flet commented May 10, 2017

Yeah, @boneskull is right in that IDE integration can be tricky if its not supported by an existing plugin. For WebStorm, it should be possible to configure it manually similar to how it can be done with standard: https://standardjs.com/webstorm.html

  • be sure to turn on them semicolons in the xml :)
  • for .eslintrc.json use {"extends": ["semistandard"]}

semistandard and standard have some ignore paths baked-in that eslint does not (including ignoring everything in .gitignore), so to remedy that, you may also need an .eslintignore file: http://eslint.org/docs/user-guide/configuring#ignoring-files-and-directories.

There are semistandard plugins for Sublime Text and VS Code which work great, but yeah it can be a pain in other IDEs :/. The JetBrains folks might be receptive to adding semistandard too, but I don't know if anyone has asked :).

For this particular PR, I'd say adding a .eslintignore file would be needed.

@boneskull
Copy link
Member Author

For this particular PR, I'd say adding a .eslintignore file would be needed.

We have an .eslintignore file already, which was not removed. This should be GTG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants