Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
replace phantomjs with puppeteer for browser tests; closes #3128
  • Loading branch information
akrawchyk authored and boneskull committed Jan 9, 2018
1 parent cb09e8b commit e54370e
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 319 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Expand Up @@ -52,6 +52,7 @@ addons:
- .karma/
- ./mocha.js
sauce_connect: true
chrome: stable
cache:
directories:
- ~/.npm
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -11,7 +11,7 @@
1. Increase test coverage on Node.js and browser
- Increase integration coverage for all reporters
- `html` reporter must be tested in browser
- ~~Basic console reporters (*not* `nyan`, `landing`, etc.) must be tested in **both** browser and Node.js contexts; PhantomJS can consume all console reporters~~
- ~~Basic console reporters (*not* `nyan`, `landing`, etc.) must be tested in **both** browser and Node.js contexts~~
- ~~Filesystem-based reporters must be tested in Node.js context~~
- **UPDATE - May 24 2017**: Thanks to [community contributions](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#mag-coverage), the coverage on most reporters has increased dramatically! The `html` reporter is still in [dire need of coverage](https://coveralls.io/builds/11674428/source?filename=lib%2Freporters%2Fhtml.js).
- Increase coverage against all interfaces (`exports` in particular). Ideally this becomes a "matrix" where we repeat sets of integration tests across all interfaces.
Expand Down
1 change: 0 additions & 1 deletion appveyor.yml
Expand Up @@ -10,7 +10,6 @@ install:
- ps: Install-Product node $env:nodejs_version x64
- set CI=true
- set PATH=%APPDATA%\npm;c:\MinGW\bin;%PATH%
- set PHANTOMJS_CDNURL=https://cnpmjs.org/downloads
- npm install -g npm
- npm install
- copy c:\MinGW\bin\mingw32-make.exe c:\MinGW\bin\make.exe
Expand Down
2 changes: 1 addition & 1 deletion karma.conf.js
Expand Up @@ -51,7 +51,7 @@ module.exports = config => {
},
reporters: ['mocha'],
colors: true,
browsers: ['PhantomJS'],
browsers: ['ChromeHeadless'],
logLevel: config.LOG_INFO,
client: {
mocha: {
Expand Down

0 comments on commit e54370e

Please sign in to comment.