Skip to content

Commit

Permalink
update coveralls strategy; closes #2984
Browse files Browse the repository at this point in the history
  • Loading branch information
boneskull committed Sep 5, 2017
1 parent 73a5338 commit aa52933
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Expand Up @@ -72,7 +72,7 @@ before_script: scripts/travis-before-script.sh

script: make $TARGET

after_success: "npm run postcoverage && <coverage/lcov.info ./node_modules/coveralls/bin/coveralls.js"
after_success: npm run coveralls

notifications:
urls:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Expand Up @@ -5,7 +5,7 @@ NYC := "node_modules/.bin/nyc"

ifdef COVERAGE
define test_node
$(NYC) --report-dir coverage/reports/$(1) $(MOCHA)
$(NYC) --no-clean --report-dir coverage/reports/$(1) $(MOCHA)
endef
else
test_node := $(MOCHA)
Expand Down
7 changes: 2 additions & 5 deletions package.json
Expand Up @@ -301,10 +301,8 @@
"scripts": {
"lint": "eslint . bin/*",
"test": "make test && make clean",
"precoverage": "rm -rf coverage",
"coverage": "COVERAGE=true npm run test",
"postcoverage": "istanbul-combine -d coverage -r lcov -r html coverage/reports/*/*.json",
"preversion": "make test && rm mocha.js && make mocha.js && git add mocha.js"
"preversion": "make test && rm mocha.js && make mocha.js && git add mocha.js",
"coveralls": "nyc report --reporter=text-lcov | coveralls"
},
"dependencies": {
"browser-stdout": "1.3.0",
Expand Down Expand Up @@ -333,7 +331,6 @@
"eslint-plugin-promise": "^3.4.0",
"eslint-plugin-standard": "2.0.1",
"expect.js": "^0.3.1",
"istanbul-combine": "^0.3.0",
"karma": "1.3.0",
"karma-browserify": "^5.0.5",
"karma-chrome-launcher": "^2.0.0",
Expand Down
4 changes: 4 additions & 0 deletions scripts/travis-before-script.sh
@@ -1,3 +1,7 @@
#!/usr/bin/env bash

# bundle artifacts to AWS go here
mkdir -p .karma

# because https://github.com/istanbuljs/nyc/pull/664
mkdir -p .nyc_output

0 comments on commit aa52933

Please sign in to comment.