Skip to content

Commit

Permalink
pfix "prepublishOnly" potential portability problem
Browse files Browse the repository at this point in the history
  • Loading branch information
@boneskull
boneskull committed Oct 3, 2017
1 parent 60e39d9 commit 171b9f9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
View file
Expand Up @@ -302,7 +302,7 @@
"lint": "eslint . bin/*",
"test": "make test && make clean",
"preversion": "npm test",
"prepublishOnly": "make test && rm mocha.js && make mocha.js",
"prepublishOnly": "rimraf mocha.js && make mocha.js",

This comment has been minimized.

Sign in to view

Copy link
@ScottFreeCode

ScottFreeCode Oct 4, 2017 •
edited

Contributor

We may want to consider moving the npm test call from preversion into prepublishOnly to ensure that there were no buggy changes between versioning and publishing and that testing occurs before publishing even if versioning is bumped manually. Consider this suggestion the more up-to-date version of #2999?
"coveralls": "nyc report --reporter=text-lcov | coveralls"
},
"dependencies": {
Expand Down

0 comments on commit 171b9f9

Please sign in to comment.