fix corner case in evaluate (#3883)

fixes #3882
mishoo · May 11, 2020 · bd2f53b · bd2f53b
1 parent e8a7956
commit bd2f53b
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 3 deletions.
diff --git a/lib/compress.js b/lib/compress.js
@@ -3268,9 +3268,14 @@ merge(Compressor.prototype, {
         });
         def(AST_Sequence, function(compressor, ignore_side_effects, cached, depth) {
             if (!ignore_side_effects) return this;
-            var node = this.tail_node();
-            var value = node._eval(compressor, ignore_side_effects, cached, depth);
-            return value === node ? this : value;
+            var tail = this.tail_node();
+            this.walk(new TreeWalker(function(node) {
+                if (node === tail) return true;
+                if (node instanceof AST_Assign) modified(node.left);
+                if (node instanceof AST_Unary && unary_arithmetic[node.operator]) modified(node.expression);
+            }));
+            var value = tail._eval(compressor, ignore_side_effects, cached, depth);
+            return value === tail ? this : value;
         });
         def(AST_Lambda, function(compressor) {
             if (compressor.option("unsafe")) {

diff --git a/test/compress/evaluate.js b/test/compress/evaluate.js
@@ -2369,3 +2369,29 @@ issue_3878_2: {
     }
     expect_stdout: "NaN"
 }
+
+issue_3882: {
+    options = {
+        evaluate: true,
+        reduce_vars: true,
+        toplevel: true,
+        unused: true,
+    }
+    input: {
+        function f(a) {
+            return console.log(a++), a && this;
+        }
+        var b = f();
+        console.log(b);
+    }
+    expect: {
+        var b = function(a) {
+            return console.log(a++), a && this;
+        }();
+        console.log(b);
+    }
+    expect_stdout: [
+        "NaN",
+        "NaN",
+    ]
+}