Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat escape token same way we treat plain text tokens #1642

Merged
merged 1 commit into from Apr 14, 2020

Conversation

Eirenliel
Copy link
Contributor

@Eirenliel Eirenliel commented Apr 13, 2020

Description

  • Treat escape token as text token for the purpose of creating custom Renderer

Expectation

Marked should alow treating escaped characters the same way it allows treating unescaped characters for the cases where we need to perform plain text transformation in the Render implementation.

Result

Escaped characters, like \# are passed to result raw, but unescaped characters are passed to Render.text() as normal.

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel
Copy link

vercel bot commented Apr 13, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/markedjs/markedjs/pyftzc0xw
✅ Preview: https://markedjs-git-fork-eirenliel-master.markedjs.now.sh

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle merged commit ab6405e into markedjs:master Apr 14, 2020
@UziTech UziTech mentioned this pull request Apr 20, 2020
12 tasks
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Treat escape token same way we treat plain text tokens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants