Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put additional links into readme #1310

Merged
merged 2 commits into from Jul 19, 2018
Merged

Put additional links into readme #1310

merged 2 commits into from Jul 19, 2018

Conversation

rumkin
Copy link
Contributor

@rumkin rumkin commented Jul 17, 2018

Description

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links won’t work when viewed from a website other than GitHub such as https://www.npmjs.com/package/marked

Can you use the full link to marked.js.org?

@styfle styfle added the category: docs Documentation changes label Jul 17, 2018
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 🎉

@styfle styfle requested review from UziTech and joshbruce July 18, 2018 21:09
@styfle styfle merged commit ac45c22 into markedjs:master Jul 19, 2018
This was referenced Apr 6, 2020
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Put additional links into readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants