Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security: use rtrim, not unsafe /X+$/ #1260

Merged
merged 3 commits into from
Jun 3, 2018
Merged

security: use rtrim, not unsafe /X+$/ #1260

merged 3 commits into from
Jun 3, 2018

Commits on May 9, 2018

  1. security: rtrim, not unsafe /X+$/ idiom 

    Problem:
replace(/X+$/, '') is vulnerable to REDOS

Solution:
Replace all instances I could find with a custom rtrim
    @davisjam
    davisjam committed May 9, 2018
    Configuration menu
    Copy the full SHA
    7e5a727 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2018

  1. address review comments

    @davisjam
    davisjam committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    2e05c77 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary if check

    @davisjam
    davisjam committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    0610f9f View commit details
    Browse the repository at this point in the history