Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added recommended ruleset #200

Merged
merged 4 commits into from Jul 17, 2019
Merged

Added recommended ruleset #200

merged 4 commits into from Jul 17, 2019

Conversation

Lakitna
Copy link
Contributor

@Lakitna Lakitna commented Jul 10, 2019

Closes #175

@lo1tuma
Copy link
Owner

lo1tuma commented Jul 15, 2019

Thanks for the PR. The preset looks good to me. It would nice if you could also add a small sentence to the README.

@Lakitna
Copy link
Contributor Author

Lakitna commented Jul 16, 2019

Good point, I'll add it later.

@Lakitna
Copy link
Contributor Author

Lakitna commented Jul 16, 2019

Ready for merge on my side :)

lo1tuma
lo1tuma approved these changes Jul 17, 2019
View reviewed changes
Copy link
Owner

@lo1tuma lo1tuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Thank you!

@lo1tuma lo1tuma merged commit ae913c5 into lo1tuma:master Jul 17, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lo1tuma lo1tuma lo1tuma approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default rules enabled / extends
2 participants
@Lakitna @lo1tuma