Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(execa): upgrade execa@9.0.2 #1414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build(execa): upgrade execa@9.0.2 #1414

wants to merge 1 commit into from

Conversation

iiroj
Copy link
Member

@iiroj iiroj commented May 12, 2024

This PR updates to the latest execa version 9, and bumps minimum required Node.js version from 18.12.0 to 18.19.0.

I wouldn't consider this a breaking change because 18 LTS is still receiving updates and the current version is at 18.20.2.

Copy link

changeset-bot bot commented May 12, 2024

🦋 Changeset detected

Latest commit: 8329266

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
lint-staged Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iiroj
Copy link
Member Author

iiroj commented May 12, 2024

What do you think, @okonet, should this be a breaking change?

Personally I would be ok with this, and only doing breaking changes when dropping support for 18 completely (in the future). IMO people should track the latest major LTS release anyway, so in this case the latest 18.20.2.

@iiroj iiroj requested a review from okonet May 12, 2024 17:30
@iiroj
Copy link
Member Author

iiroj commented May 12, 2024

Following the Semver spec strictly would indeed make this breaking change, if we assume people don't update their Node.js 18 version or are for some reason locked to an older one.

@fetwar
Copy link

fetwar commented May 23, 2024

Personally I think this should be considered a breaking change as per semver, at least that way there is less chance of someone missing the node version upgrade thinking there aren't any breaking changes... then breaking their build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants