Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pkg argument optional for lerna diff #831

Merged
merged 1 commit into from May 21, 2017

Conversation

evocateur
Copy link
Member

@evocateur evocateur commented May 21, 2017

Motivation and Context

Some awkwardness crept into lerna diff during recent refactoring. This cleans it up.

Fixes #816

How Has This Been Tested?

existing unit tests pass

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@evocateur
Copy link
Member Author

I'm getting really tired of the node 4 AppVeyor build timing out during the integration tests. 😠

@evocateur evocateur changed the title Make pkg argument optional for lerna diff, disable progress bar Make pkg argument optional for lerna diff May 21, 2017
@evocateur evocateur merged commit f0b250a into lerna:master May 21, 2017
@evocateur evocateur deleted the fix-diff-no-arg branch May 21, 2017 20:28
treshugart pushed a commit to treshugart/lerna that referenced this pull request May 24, 2017
This also hides the progress bar, which is not needed for diff.

Fixes lerna#816
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lerna diff without package fails
1 participant