Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to fs-extra #828

Merged
merged 3 commits into from May 19, 2017
Merged

Switch to fs-extra #828

merged 3 commits into from May 19, 2017

Conversation

evocateur
Copy link
Member

@evocateur evocateur commented May 19, 2017

Description

Switch fs-promise to fs-extra, now that fs-promise is deprecated.

Motivation and Context

fs-extra 3 gives us what we got from fs-promise, except with less indirection. It also avoids the noisy deprecation warning during installation.

This builds on #827

How Has This Been Tested?

existing unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@evocateur evocateur merged commit 64203e5 into lerna:master May 19, 2017
@evocateur evocateur deleted the fs-extra branch May 19, 2017 19:33
treshugart pushed a commit to treshugart/lerna that referenced this pull request May 24, 2017
This avoids a loud deprecation warning during installation.

fs-extra 3.x now provides the Promise API we were using fs-promise for.
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant