Add --only-updated option to exec and run subcommands #726

jameslnewell · 2017-04-03T03:47:16Z

Description

I have added a new flag that only runs/execs packages that have been updated.

Works with scope so that only packages that match the scope AND that have been updated will be run/exec.

Motivation and Context

I have a situation where package B depends on package A. I've made a breaking change to package A and want to release package A, but I don't want/have-time to update package B to work with these changes yet. When lerna run typescript runs on package B, it will fail because the version of package A hasn't been bumped yet and lerna is symlinking the latest package A to package B.

lerna run --only-updated typescript will allow me to publish package A, re-run lerna bootstrap to install the previous version of package A in package B (instead of a symlink) and enable me to continue developing package B independently of package A.

How Has This Been Tested?

Minimal manual tests checking the run and exec commands, with and without the scope flag.

e.g.

lerna run --scope "my-component-*" --only-updated -- build
lerna exec --scope "my-component-*" --only-updated -- echo

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes. (there were no existing tests to copy from for filteredPackages - will happily add some with guidance)
All new and existing tests passed.

… that have been updated

evocateur

This needs unit tests to validate.

I've got some easier-to-grok unit tests coming in #714.

evocateur · 2017-04-06T01:21:43Z

src/Command.js

@@ -182,6 +183,13 @@ export default class Command {
      if (this.getOptions().includeFilteredDependencies) {
        this.filteredPackages = PackageUtilities.addDependencies(this.filteredPackages, this.packageGraph);
      }
+      if (this.flags.onlyUpdated) {


This belongs in ExecCommand and RunCommand, not the base class, yes?

Looks like it'll also work for clean, ls and bootstrap however I can move the logic to a utility fn and call it separately in exec and run if you prefer.

Well, consider that those other commands really have no use for this flag, and might even be considered broken if they were to adhere to it. I would recommend a separate shared file to encapsulate, yes.

😎 will refactor

jameslnewell · 2017-04-17T22:47:37Z

src/PackageUtilities.js

@@ -138,6 +139,14 @@ export default class PackageUtilities {
    return packages;
  }

+  static filterPackagesThatAreNotUpdated(packagesToFilter, command) {


Taking the whole command here feels a bit gross, but couldn't think of an alternative.

jameslnewell · 2017-04-18T00:38:35Z

@evocateur I've thrown together some tests and moved the code into the specific commands (meaning there's now some duplication). Let me know if you'd like me to change anything else.

bradleyayers · 2017-04-18T00:54:51Z

src/commands/ExecCommand.js

-export const builder = {};
+export const builder = {
+  "only-updated": {
+    "describe": "When exectuting scripts/commands, only run the script/command on packages which "


exectuting

bradleyayers · 2017-04-18T00:55:54Z

src/commands/RunCommand.js

@@ -13,6 +13,10 @@ export const describe = "Run an npm script in each package that contains that sc
 export const builder = {
  "stream": {
    describe: "Stream output with lines prefixed by package."
+  },
+  "only-updated": {
+    "describe": "When exectuting scripts/commands, only run the script/command on packages which "


exectuting

bradleyayers · 2017-04-18T00:56:51Z

README.md

@@ -654,6 +654,18 @@ $ lerna bootstrap --scope "package-*" --ignore "package-util-*" --include-filter
 # package matched by "package-*"
 ```

+#### --only-updated
+
+When exectuting a script or command, only run the script or command on packages that have been updated since the last release.


exectuting

bradleyayers · 2017-04-18T00:57:59Z

README.md

@@ -654,6 +654,18 @@ $ lerna bootstrap --scope "package-*" --ignore "package-util-*" --include-filter
 # package matched by "package-*"
 ```

+#### --only-updated
+
+When exectuting a script or command, only run the script or command on packages that have been updated since the last release.


It'd be nice to clarify the semantics of what updated means. Perhaps just add to this sentence:

A package is considered "updated" using the same rules as lerna updated.

jameslnewell · 2017-04-27T00:57:49Z

@evocateur The tests are all passing but npm is getting an exit status of 0 on node v4 without any visible error. How can I re-run the tests or debug what's going wrong?

evocateur · 2017-04-27T04:19:54Z

`nvm use 4 && yarn ci`

…

On Apr 26, 2017, at 17:57, James Newell ***@***.***> wrote: @evocateur The tests are all passing but npm is getting an exit status of 0 on node v4 without any visible error. How can I re-run the tests or debug the issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

evocateur · 2017-05-01T16:28:50Z

test/PackageUtilities.js

+      expect(updatedPackages).toHaveLength(0);
+    });
+
+    it.only("should return only packages that are to be filtered and have been updated", () => {


we should definitely break lint when something like it.only is committed...

jameslnewell · 2017-05-03T00:58:02Z

The failures in node v4 appear to be in the ChildProcessUtilities.js which I haven't touched???

 PASS  test/ChildProcessUtilities.js
  ● Console

    console.error node_modules/core-js/modules/es6.promise.js:117
      Unhandled promise rejection { [Error: stdout maxBuffer exceeded] stream: 'stdout' }
    console.error node_modules/core-js/modules/es6.promise.js:117
      Unhandled promise rejection { [Error: spawn nowImTheModelOfAModernMajorGeneral ENOENT]
        code: 'ENOENT',
        errno: 'ENOENT',
        syscall: 'spawn nowImTheModelOfAModernMajorGeneral',
        path: 'nowImTheModelOfAModernMajorGeneral',
        spawnargs: [],
        killed: false,
        stdout: '',
        stderr: '',
        failed: true,
        signal: null,
        cmd: 'nowImTheModelOfAModernMajorGeneral',
        timedOut: false }
    console.error node_modules/core-js/modules/es6.promise.js:117
      Unhandled promise rejection { [Error: spawn theVeneratedVirginianVeteranWhoseMenAreAll ENOENT]
        code: 'ENOENT',
        errno: 'ENOENT',
        syscall: 'spawn theVeneratedVirginianVeteranWhoseMenAreAll',
        path: 'theVeneratedVirginianVeteranWhoseMenAreAll',
        spawnargs: [],
        killed: false,
        stdout: '',
        stderr: '',
        failed: true,
        signal: null,
        cmd: 'theVeneratedVirginianVeteranWhoseMenAreAll',
        timedOut: false }

Edit: @evocateur I get those same errors on master in node v4

jameslnewell · 2017-05-11T05:29:23Z

hey @evocateur anything I can do to get this merged?

evocateur · 2017-05-18T20:37:19Z

@jameslnewell Thanks for your patience!

benoj · 2018-05-31T11:05:09Z

Is this still in the project? Don't see this in the README anymore and it is just what I am looking for!

evocateur · 2018-05-31T14:40:33Z

Should be achievable with `--since`

…

On May 31, 2018, at 04:05, Ben Flowers ***@***.***> wrote: Is this still in the project? Don't see this in the README anymore and it is just what I am looking for! — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

lock · 2018-12-27T04:25:07Z

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

James Newell added 2 commits April 3, 2017 13:31

added a new flag (--only-updated) that only runs run/exec on packages…

d95edc8

… that have been updated

updated doco and removed console log

57c0cde

evocateur suggested changes Apr 6, 2017

View reviewed changes

James Newell added 2 commits April 18, 2017 08:29

merge conflicts

08c0907

re-implement functionality in only exec and run commands

4bc30d6

jameslnewell commented Apr 17, 2017

View reviewed changes

added tests

fadc4ce

removed obsolete snapshots

e2db1a6

bradleyayers suggested changes Apr 18, 2017

View reviewed changes

James Newell and others added 3 commits April 18, 2017 11:05

fix spelling and docs

2eeef72

remove .only

8e1f9d8

Merge branch 'master' into master

5f809bd

evocateur reviewed May 1, 2017

View reviewed changes

remove .only

9f08068

jameslnewell and others added 2 commits May 3, 2017 11:02

Merge branch 'master' into master

ce9c9ea

serves me right for using Github to resolve conflicts

7b4dcb0

evocateur approved these changes May 18, 2017

View reviewed changes

evocateur changed the title ~~added a new flag that only runs/execs packages that have been updated~~ Add --only-updated option to exec and run subcommands May 18, 2017

evocateur added the Tag: Enhancement label May 18, 2017

evocateur merged commit 22bad8b into lerna:master May 18, 2017

evocateur mentioned this pull request May 18, 2017

Add --since flag to all commands that accept --scope #822

Merged

9 tasks

lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add --only-updated option to exec and run subcommands #726

Add --only-updated option to exec and run subcommands #726

jameslnewell commented Apr 3, 2017 •

edited

evocateur left a comment

evocateur Apr 6, 2017

jameslnewell Apr 6, 2017

evocateur Apr 6, 2017

jameslnewell Apr 6, 2017

jameslnewell Apr 17, 2017

jameslnewell commented Apr 18, 2017

bradleyayers Apr 18, 2017

jameslnewell Apr 18, 2017

bradleyayers Apr 18, 2017

bradleyayers Apr 18, 2017

bradleyayers Apr 18, 2017

jameslnewell commented Apr 27, 2017 •

edited

evocateur commented Apr 27, 2017 via email

evocateur May 1, 2017

jameslnewell May 3, 2017

jameslnewell commented May 3, 2017 •

edited

jameslnewell commented May 11, 2017

evocateur commented May 18, 2017

benoj commented May 31, 2018

evocateur commented May 31, 2018 via email

lock bot commented Dec 27, 2018

Add --only-updated option to exec and run subcommands #726

Add --only-updated option to exec and run subcommands #726

Conversation

jameslnewell commented Apr 3, 2017 • edited

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

evocateur left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jameslnewell commented Apr 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jameslnewell commented Apr 27, 2017 • edited

evocateur commented Apr 27, 2017 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jameslnewell commented May 3, 2017 • edited

jameslnewell commented May 11, 2017

evocateur commented May 18, 2017

benoj commented May 31, 2018

evocateur commented May 31, 2018 via email

lock bot commented Dec 27, 2018

jameslnewell commented Apr 3, 2017 •

edited

jameslnewell commented Apr 27, 2017 •

edited

jameslnewell commented May 3, 2017 •

edited